From: Pavel Roskin <proski@gnu.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Michael Buesch <mb@bu3sch.de>,
John W Linville <linville@tuxdriver.com>,
chunkeey@web.de, linux-wireless@vger.kernel.org
Subject: Re: [RFC/RFT] p54: Fix sparse warnings
Date: Wed, 17 Sep 2008 12:15:31 -0400 [thread overview]
Message-ID: <1221668131.18202.10.camel@dv> (raw)
In-Reply-To: <48CBDF0B.5080303@lwfinger.net>
On Sat, 2008-09-13 at 10:40 -0500, Larry Finger wrote:
> Michael Buesch wrote:
> > On Friday 12 September 2008 20:52:52 Larry Finger wrote:
> >> No, it won't avoid any casts. The program uses the data area 7 times
> >> in native-cpu order, once as be32, and once in little-endian order
> >
> > Is the native use correct? Smells fishy.
>
> It does to me as well.
I think we should assume fixed byte order unless the hardware is
programmed differently for big-endian hosts (e.g. Atheros chipsets can
byte-swap some registers). If the driver is working on little-endian
systems, we should assume little-endian data unless testing proves us to
be wrong.
> I just got a copy of Intersil's data sheet for
> the MAC and everything looks little endian, but until we get a tester
> with a big-endian machine, we won't know. So far, no volunteers have
> come forward.
I have a PowerMac and a Prism54 card, so I can test.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-09-17 16:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-12 18:16 [RFC/RFT] p54: Fix sparse warnings Larry Finger
2008-09-12 18:36 ` Michael Buesch
2008-09-12 18:39 ` Michael Buesch
2008-09-12 18:52 ` Larry Finger
2008-09-13 12:40 ` Michael Buesch
2008-09-13 15:40 ` Larry Finger
2008-09-17 16:15 ` Pavel Roskin [this message]
2008-09-17 17:16 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1221668131.18202.10.camel@dv \
--to=proski@gnu.org \
--cc=Larry.Finger@lwfinger.net \
--cc=chunkeey@web.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).