From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: Tomas Winkler <tomasw@gmail.com>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] mac80211: re-enable aggregation
Date: Thu, 18 Sep 2008 01:05:57 +0200 [thread overview]
Message-ID: <1221692757.7412.22.camel@localhost> (raw)
In-Reply-To: <20080917230357.GA7410@tesla>
On Wed, 2008-09-17 at 16:03 -0700, Luis R. Rodriguez wrote:
> > What I need to next is to add is rtnl_lock
> > qdisc_root_lock requires this. This root lock is held during requeuing
> > which can be triggered by removal or addition of an aggregation queue.
>
> I saw that, but rtnl_lock() is mutex basd so no good. Hence we need
> something that works around this.
As I outlined earlier I'm pretty much convinced you need to go to the
workqueue anyway. Use schedule_work though, not the mac80211 workqueue,
you can't take the rtnl on the mac80211 wq.
johannes
next prev parent reply other threads:[~2008-09-17 23:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-16 3:17 [PATCH v2] mac80211: re-enable aggregation Luis R. Rodriguez
2008-09-16 3:30 ` Luis R. Rodriguez
2008-09-16 6:37 ` Johannes Berg
2008-09-17 20:57 ` Tomas Winkler
2008-09-17 22:45 ` Luis R. Rodriguez
2008-09-17 22:57 ` Tomas Winkler
2008-09-17 23:03 ` Luis R. Rodriguez
2008-09-17 23:05 ` Johannes Berg [this message]
2008-09-17 23:20 ` Tomas Winkler
2008-09-17 23:45 ` Tomas Winkler
-- strict thread matches above, loose matches on Subject: below --
2008-10-21 7:14 [PATCH v2] mac80211: Re-enable aggregation Sujith
2008-10-21 7:24 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1221692757.7412.22.camel@localhost \
--to=johannes@sipsolutions.net \
--cc=Luis.Rodriguez@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).