From: Pavel Roskin <proski@gnu.org>
To: Marcel Holtmann <holtmann@linux.intel.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iw: add kernel version checks for pending upstream kernel features
Date: Thu, 18 Sep 2008 15:19:07 -0400 [thread overview]
Message-ID: <1221765547.9477.4.camel@dv> (raw)
In-Reply-To: <1221758783.6782.29.camel@californication>
On Thu, 2008-09-18 at 19:26 +0200, Marcel Holtmann wrote:
> if the numbers you are planning to use are stable, then please use the
> above approach to just add the missing defines to it. Like adding a
> compat.h file with
>
> #ifndef NL80211_ATTR_SUPPORTED_IFTYPES
> #define NL80211_ATTR_SUPPORTED_IFTYPES boo
> #endif
I'm sure the numbers used to communicate between the kernel and the
userspace are meant to be stable.
> That would make a distro complied binary work with an updates kernel and
> we don't end up with the issue the iwconfig current has when it has been
> compiled for an older kernel.
Having the include file in the sources would have the same effect.
But your approach is easier to get wrong. Some numbers are from enum,
not from preprocessor defines. It's easy to put a wrong number into the
compatibility code. This code will need to be tested on older kernels.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-09-18 19:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 14:35 [PATCH] iw: add kernel version checks for pending upstream kernel features John W. Linville
2008-09-18 15:13 ` Pavel Roskin
2008-09-18 15:41 ` Johannes Berg
2008-09-18 16:10 ` Pavel Roskin
2008-09-18 17:26 ` Marcel Holtmann
2008-09-18 17:28 ` Johannes Berg
2008-09-18 20:43 ` Marcel Holtmann
2008-09-18 19:19 ` Pavel Roskin [this message]
2008-09-19 1:25 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1221765547.9477.4.camel@dv \
--to=proski@gnu.org \
--cc=holtmann@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).