From: Mattias Nissler <mattias.nissler@gmx.de>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: "Mikko Virkkilä" <mikko.virkkila@bluegiga.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
rt2400-devel@lists.sourceforge.net,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC][PATCH] TX status reporting with help of an ack queue
Date: Thu, 18 Sep 2008 20:37:00 +0000 [thread overview]
Message-ID: <1221770220.4563.3.camel@localhost> (raw)
In-Reply-To: <200809162018.42576.IvDoorn@gmail.com>
On Tue, 2008-09-16 at 20:18 +0200, Ivo van Doorn wrote:
> > > Good point :-) So I suggest we have one function that adds new packets
> > > to the ACK queue (which is represented by a struct an instance of which
> > > a driver can keep in its queue information) and another one that matches
> > > a received ACK with the queue, reports the status to mac80211 and purges
> > > the queue entries up to the match (reporting them as failed).
> > >
> > > Mikko: I could hack this up, but since your initial patch is not far
> > > from what's been discussed, I rather wait for a comment on whether you
> > > want to do it.
> > >
> > > Mattias
> > >
> >
> > Feel free to hack up a patch. The functions
> > rt2x00lib_get_match_from_ack_queue and rt2x00lib_push_to_ack_queue are
> > already generic handlers for the queue.
>
> Mattias, please note my comments on Mikko's patch if you are going to copy them. :)
Ok, I'm picking this thingy up. I've got some time tomorrow, but I'll be
away for the weekend, so expect something at the beginning of next week.
Mattias
next prev parent reply other threads:[~2008-09-18 20:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1221494693.14102.22.camel@virkkmi-linux>
2008-09-15 17:11 ` [RFC][PATCH] TX status reporting with help of an ack queue Ivo van Doorn
2008-09-15 17:56 ` Mattias Nissler
2008-09-15 18:03 ` Johannes Berg
2008-09-15 19:00 ` Mattias Nissler
2008-09-15 19:21 ` Johannes Berg
2008-09-15 19:39 ` Mattias Nissler
2008-09-15 19:46 ` Johannes Berg
2008-09-15 20:20 ` Mattias Nissler
2008-09-15 20:33 ` Johannes Berg
2008-09-15 21:01 ` Mattias Nissler
2008-09-24 0:59 ` John W. Linville
2008-09-24 7:40 ` Mattias Nissler
2008-09-24 8:34 ` Johannes Berg
2008-09-15 21:28 ` Ivo van Doorn
2008-09-15 21:41 ` Mattias Nissler
2008-09-16 18:17 ` Ivo van Doorn
2008-09-17 23:08 ` Mattias Nissler
2008-09-16 6:24 ` Mikko Virkkilä
2008-09-16 4:58 ` Mikko Virkkilä
2008-09-16 18:18 ` Ivo van Doorn
2008-09-18 20:37 ` Mattias Nissler [this message]
2008-09-18 22:29 ` ACK matching [was: TX status reporting with help of an ack queue] Mattias Nissler
2008-09-19 9:08 ` Mikko Virkkilä
2008-09-19 9:46 ` Mattias Nissler
2008-09-19 9:54 ` Johannes Berg
2008-09-19 10:19 ` Mattias Nissler
2008-09-19 10:31 ` Johannes Berg
2008-09-19 13:51 ` Mattias Nissler
2008-09-19 13:55 ` Johannes Berg
2008-09-19 14:20 ` Mikko Virkkilä
2008-09-19 17:50 ` Jouni Malinen
2008-09-23 6:09 ` Mikko Virkkilä
2008-09-23 7:05 ` Mattias Nissler
2008-09-19 18:30 ` Ivo van Doorn
2008-10-19 5:49 ` Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1221770220.4563.3.camel@localhost \
--to=mattias.nissler@gmx.de \
--cc=ivdoorn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mikko.virkkila@bluegiga.com \
--cc=rt2400-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).