From: Marcel Holtmann <holtmann@linux.intel.com>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: Arjan van de Ven <arjan@infradead.org>,
Johannes Berg <johannes@sipsolutions.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ipw2100-devel@lists.sourceforge.net,
linux-wireless@vger.kernel.org, yi.zhu@intel.com,
reinette.chatre@intel.com, jgarzik@pobox.com,
linville@tuxdriver.com, davem@davemloft.net
Subject: Re: Mark IPW2100 as BROKEN: Fatal interrupt. Scheduling firmware restart.
Date: Mon, 22 Sep 2008 01:27:47 +0200 [thread overview]
Message-ID: <1222039667.6782.125.camel@californication> (raw)
In-Reply-To: <20080921210554.GA2135@2ka.mipt.ru>
Hi Evgeniy,
> > > That allows to dump whatever number of warnings you want. The more we
> > > have, the louder will be customers scream.
> >
> > artificially increasing numbers isn't going to do that; it just shows
> > you're more interested in making a stink than in getting something
> > improved ;(
>
> As practice shows, I'm the only one who is interested in getting
> something improved, and Intel, as we see right now, is not interested in
> it at all, since you ask me not only decrease error verbosity, but also
> do not work towards fixing the bug by trying to understand where it
> lives.
as Arjan and Alan pointed out already, WARN_ON_ONCE is enough and I
agree with them. Just to make this perfectly clear, this is with my
community hat on.
Please send a proper patch with a simple WARN_ON_ONCE and I am happy to
sign off on it.
Regards
Marcel
next prev parent reply other threads:[~2008-09-21 23:26 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-21 17:23 Mark IPW2100 as BROKEN: Fatal interrupt. Scheduling firmware restart Evgeniy Polyakov
2008-09-21 17:36 ` Michael Buesch
2008-09-21 17:38 ` Evgeniy Polyakov
2008-09-21 18:04 ` Arjan van de Ven
2008-09-21 18:28 ` Evgeniy Polyakov
2008-09-21 18:35 ` Arjan van de Ven
2008-09-21 18:52 ` Wei Weng
2008-09-21 19:20 ` Arjan van de Ven
2008-09-21 19:00 ` Evgeniy Polyakov
2008-09-21 19:14 ` Johannes Berg
2008-09-21 19:38 ` Evgeniy Polyakov
2008-09-21 19:43 ` Arjan van de Ven
2008-09-21 20:20 ` Evgeniy Polyakov
2008-09-21 20:27 ` Arjan van de Ven
2008-09-21 20:57 ` Evgeniy Polyakov
2008-09-21 21:02 ` Arjan van de Ven
2008-09-21 21:05 ` Evgeniy Polyakov
2008-09-21 21:14 ` Arjan van de Ven
2008-09-21 21:43 ` Denys Fedoryshchenko
2008-09-21 22:07 ` Evgeniy Polyakov
2008-09-21 22:15 ` Denys Fedoryshchenko
2008-09-21 23:46 ` Evgeniy Polyakov
2008-09-21 23:27 ` Marcel Holtmann [this message]
2008-09-22 0:00 ` Evgeniy Polyakov
2008-09-21 22:38 ` Alan Cox
2008-09-21 23:44 ` Evgeniy Polyakov
2008-09-21 23:48 ` David Miller
2008-09-22 0:18 ` Evgeniy Polyakov
2008-09-21 20:05 ` Cyrill Gorcunov
2008-09-21 20:26 ` Evgeniy Polyakov
2008-09-21 20:35 ` Cyrill Gorcunov
2008-09-21 21:06 ` Evgeniy Polyakov
2008-09-21 19:57 ` Alan Cox
2008-09-21 21:10 ` Evgeniy Polyakov
2008-09-26 5:56 ` Evgeniy Polyakov
2008-09-21 19:35 ` Marcel Holtmann
2008-09-21 21:12 ` Evgeniy Polyakov
2008-09-21 22:45 ` Matthew Garrett
2008-09-21 22:42 ` Matthew Garrett
2008-09-21 23:45 ` Evgeniy Polyakov
2008-09-22 16:21 ` [Ipw2100-devel] " Kenneth Crudup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222039667.6782.125.camel@californication \
--to=holtmann@linux.intel.com \
--cc=arjan@infradead.org \
--cc=davem@davemloft.net \
--cc=ipw2100-devel@lists.sourceforge.net \
--cc=jgarzik@pobox.com \
--cc=johannes@sipsolutions.net \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).