From: Dan Williams <dcbw@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Zhu Yi <yi.zhu@intel.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Abhijeet Kolekar <abhijeet.kolekar@intel.com>
Subject: Re: [PATCH] iwl3945: added channel sysfs entry
Date: Wed, 24 Sep 2008 06:52:10 -0400 [thread overview]
Message-ID: <1222253530.26675.11.camel@localhost.localdomain> (raw)
In-Reply-To: <1222245882.18015.62.camel@johannes.berg>
On Wed, 2008-09-24 at 10:44 +0200, Johannes Berg wrote:
> On Wed, 2008-09-24 at 13:57 +0800, Zhu Yi wrote:
> > From: Abhijeet Kolekar <abhijeet.kolekar@intel.com>
> >
> > The patch adds channels sysfs entry for iwl3945. Make it consistent
> > with iwlagn.
>
> I advocate just make it consistent by removing it entirely.
>
> > --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
> > +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> > @@ -7666,8 +7666,60 @@ static DEVICE_ATTR(power_level, S_IWUSR | S_IRUSR, show_power_level,
> > static ssize_t show_channels(struct device *d,
> > struct device_attribute *attr, char *buf)
> > {
> > - /* all this shit doesn't belong into sysfs anyway */
Yeah, it seems odd.
Dan
next prev parent reply other threads:[~2008-09-24 10:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 5:57 [PATCH] iwl3945: added channel sysfs entry Zhu Yi
2008-09-24 5:57 ` [PATCH] iwlwifi: don't fail if scan is issued too early Zhu Yi
2008-09-24 8:44 ` [PATCH] iwl3945: added channel sysfs entry Johannes Berg
2008-09-24 10:52 ` Dan Williams [this message]
2008-09-25 7:34 ` Zhu Yi
2008-09-25 9:23 ` Johannes Berg
2008-09-25 11:04 ` Tomas Winkler
2008-09-25 11:21 ` Johannes Berg
2008-09-25 11:50 ` Tomas Winkler
2008-09-26 3:54 ` Zhu Yi
2008-09-26 4:13 ` Luis R. Rodriguez
2008-09-26 5:13 ` Zhu Yi
2008-09-26 5:16 ` Zhu Yi
2008-09-26 5:28 ` Zhu Yi
2008-09-26 5:39 ` Luis R. Rodriguez
2008-09-26 5:40 ` Luis R. Rodriguez
2008-09-26 5:44 ` Zhu Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222253530.26675.11.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=abhijeet.kolekar@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).