From: Dan Williams <dcbw@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wireless: consolidate on a single escape_essid implementation
Date: Thu, 25 Sep 2008 12:47:59 -0400 [thread overview]
Message-ID: <1222361279.14444.6.camel@localhost.localdomain> (raw)
In-Reply-To: <1222318157.10563.22.camel@johannes.berg>
On Thu, 2008-09-25 at 06:49 +0200, Johannes Berg wrote:
> On Thu, 2008-09-25 at 06:46 +0200, Johannes Berg wrote:
>
> > > + essid_len = min(essid_len, (u8) IW_ESSID_MAX_SIZE);
> > > + while (essid_len--) {
> > > + if (*s == '\0') {
> > > + *d++ = '\\';
> > > + *d++ = '0';
> > > + s++;
> > > + } else {
> > > + *d++ = *s++;
> > > + }
> > > + }
> > > + *d = '\0';
> > > + return escaped;
> > > +}
> > > +EXPORT_SYMBOL(escape_essid);
>
> Also, it seems like this should escape any non-printable characters, not
> just NUL?
Yes, it should escape any _non-ASCII_ characters.
Dan
next prev parent reply other threads:[~2008-09-25 16:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 22:15 [PATCH] wireless: consolidate on a single escape_essid implementation John W. Linville
2008-09-24 23:24 ` Luis R. Rodriguez
2008-09-24 23:32 ` John W. Linville
2008-09-25 0:21 ` Luis R. Rodriguez
2008-09-25 0:39 ` John W. Linville
2008-09-25 1:52 ` Luis R. Rodriguez
2008-09-25 6:34 ` Holger Schurig
2008-09-25 8:43 ` Johannes Berg
2008-09-25 16:57 ` Dan Williams
2008-09-26 11:08 ` Johannes Berg
2008-09-26 14:51 ` Johannes Berg
2008-09-26 14:57 ` Johannes Berg
2008-09-25 23:03 ` Dave
2008-09-25 4:46 ` Johannes Berg
2008-09-25 4:49 ` Johannes Berg
2008-09-25 16:47 ` Dan Williams [this message]
2008-09-25 16:48 ` Dan Williams
2008-09-25 21:00 ` Dave
2008-10-01 2:15 ` [PATCH 0/5] wireless: single escape_essid implementation and related cleanups John W. Linville
2008-10-01 2:15 ` [PATCH 1/5] wireless: consolidate on a single escape_essid implementation John W. Linville
2008-10-01 2:15 ` [PATCH 2/5] wireless: remove NETWORK_EMPTY_ESSID flag John W. Linville
2008-10-01 2:15 ` [PATCH 3/5] wireless: escape_ssid should handle non-printables John W. Linville
2008-10-01 2:15 ` [PATCH 4/5] wireless: use individual buffers for printing ssid values John W. Linville
2008-10-01 2:15 ` [PATCH 5/5] wireless: avoid some net/ieee80211.h vs. linux/ieee80211.h conflicts John W. Linville
2008-10-01 9:25 ` [PATCH 0/5] wireless: single escape_essid implementation and related cleanups Johannes Berg
2008-10-02 19:10 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222361279.14444.6.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).