Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Rami Rosen <ramirose@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: remove wme_tx_queue and wme_rx_queue from net/mac80211/sta_info.h
Date: Fri, 26 Sep 2008 13:06:08 +0200	[thread overview]
Message-ID: <1222427168.10563.106.camel@johannes.berg> (raw)
In-Reply-To: <eb3ff54b0809251045m47949af5u6a1615f0d42d37a2@mail.gmail.com> (sfid-20080925_194506_775357_1469676E)

[-- Attachment #1: Type: text/plain, Size: 820 bytes --]

On Thu, 2008-09-25 at 20:45 +0300, Rami Rosen wrote:
> Hi,
>   This patch removes wme_tx_queue and wme_rx_queue from net/mac80211/sta_info.h
>   as they are not used. (These variable names in fact a double declaration; one
>   is a pointer to dentry struct (for DEBUGFS) and the second is an
> array of ints
>  (for Extra statistics for TX/RX debugging - when setting
>  CONFIG_MAC80211_DEBUG_COUNTERS); both are not used.

Not really a double declaration since one of them is in the debugfs
sub-structure, but yeah, useless.

> 
> 	
> Regards,
> Rami Rosen
> 	
> Signed-off-by: Rami Rosen <ramirose@gmail.com>

Acked-by: Johannes Berg <johannes@sipsolutions.net>

but you may need to resend with a patch description appropriate for the
changelog, I'll let John sort that out I guess.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2008-09-26 11:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-25 17:45 [PATCH] mac80211: remove wme_tx_queue and wme_rx_queue from net/mac80211/sta_info.h Rami Rosen
2008-09-26 11:06 ` Johannes Berg [this message]
2008-09-26 11:56   ` [PATCH] [RESEND] " Rami Rosen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1222427168.10563.106.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=ramirose@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox