linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <holtmann@linux.intel.com>
To: Tomas Winkler <tomasw@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	John Linville <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] iwlwifi: get rid of IWL_{GET,SET}_BITS crap
Date: Mon, 06 Oct 2008 21:12:34 +0200	[thread overview]
Message-ID: <1223320354.11272.224.camel@violet.holtmann.net> (raw)
In-Reply-To: <1ba2fa240810061135t24f2dfbv2a5eb0cd5d9e8cd7@mail.gmail.com>

Hi Tomas,

> > This makes the code surrounding the last few things using
> > IWL_SET_BITS16 actually readable and removes the macros
> > so nobody will ever consider using them again.
> >
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> 
> I don't want these macros eithers but I NACK any patches with cursing
> in the commit logs.

did I miss an internal joke here? I fail to see the cursing ;)

Regards

Marcel



  reply	other threads:[~2008-10-06 19:12 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-06 16:50 [PATCH] iwlwifi: get rid of IWL_{GET,SET}_BITS crap Johannes Berg
2008-10-06 17:45 ` Johannes Berg
2008-10-06 17:49 ` [PATCH v2] " Johannes Berg
2008-10-06 18:18   ` Marcel Holtmann
2008-10-06 18:24     ` Johannes Berg
2008-10-06 18:35 ` [PATCH] " Tomas Winkler
2008-10-06 19:12   ` Marcel Holtmann [this message]
2008-10-06 20:24     ` drago01
2008-10-06 21:32       ` Christoph Hellwig
2008-10-07  6:21   ` Holger Schurig
2008-10-07  7:15     ` Christoph Hellwig
2008-10-07 13:16       ` John W. Linville
2008-10-07 14:03         ` Tomas Winkler
2008-10-07 16:58           ` Johannes Berg
2008-10-07 19:28             ` Tomas Winkler
2008-10-07 19:34               ` Johannes Berg
2008-10-07 19:39                 ` Johannes Berg
2008-10-07 20:06                   ` Tomas Winkler
2008-10-07 20:10                     ` Johannes Berg
2008-10-07 20:46                       ` Tomas Winkler
2008-10-08  8:02                         ` Johannes Berg
2008-10-08 12:38                           ` Tomas Winkler
2008-10-09  9:52                             ` Johannes Berg
2008-10-09 16:35                               ` Tomas Winkler
2008-10-07 20:01                 ` Tomas Winkler
2008-10-07 20:06                   ` Johannes Berg
2008-10-07 20:08                     ` Tomas Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1223320354.11272.224.camel@violet.holtmann.net \
    --to=holtmann@linux.intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=tomasw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).