From: Krzysztof Kozlowski <krzk@kernel.org>
To: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com>,
jjohnson@kernel.org, johannes@sipsolutions.net, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Baochen Qiang <baochen.qiang@oss.qualcomm.com>
Subject: Re: [PATCH v2 ath-current 1/2] wifi: ath11k: add usecase firmware handling based on device compatible
Date: Tue, 13 Jan 2026 08:30:31 +0100 [thread overview]
Message-ID: <12234020-267c-4d62-baff-89e6d053f24e@kernel.org> (raw)
In-Reply-To: <20251214025230.716387-2-miaoqing.pan@oss.qualcomm.com>
On 14/12/2025 03:52, Miaoqing Pan wrote:
> For M.2 WLAN chips, there is no suitable DTS node to specify the
> firmware-name property. In addition, assigning firmware for the
> M.2 PCIe interface causes chips that do not use usecase specific
> firmware to fail. Therefore, abandoning the approach of specifying
> firmware in DTS. As an alternative, propose a static lookup table
> mapping device compatible to firmware names. Currently, only WCN6855
> HW2.1 requires this.
>
> For details on usecase specific firmware, see:
> https://lore.kernel.org/all/20250522013444.1301330-3-miaoqing.pan@oss.qualcomm.com/.
>
> Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-04685-QCAHSPSWPL_V1_V2_SILICONZ_IOE-1
>
> Fixes: edbbc647c4f3 ("wifi: ath11k: support usercase-specific firmware overrides")
> Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
> Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com>
> ---
I already said why it is wrong patch and you did not improve. You also
added tags from reviews of something completely different, which
effectively bypassed my filters. I find it unacceptable.
Let me mark it formally:
NAK
Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-13 7:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-14 2:52 [PATCH v2 ath-current 0/2]] wifi: ath11k: add usecase firmware handling based on device compatible Miaoqing Pan
2025-12-14 2:52 ` [PATCH v2 ath-current 1/2] " Miaoqing Pan
2026-01-13 7:30 ` Krzysztof Kozlowski [this message]
2025-12-14 2:52 ` [PATCH v2 ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: remove obsolete firmware-name property Miaoqing Pan
2026-01-13 7:28 ` Krzysztof Kozlowski
2026-01-19 1:34 ` Miaoqing Pan
2026-01-19 7:08 ` Krzysztof Kozlowski
2026-01-19 13:17 ` Miaoqing Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12234020-267c-4d62-baff-89e6d053f24e@kernel.org \
--to=krzk@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=baochen.qiang@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jjohnson@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miaoqing.pan@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox