* iwlwifi workqueue
@ 2008-10-15 21:47 Johannes Berg
2008-10-16 1:58 ` Zhu Yi
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2008-10-15 21:47 UTC (permalink / raw)
To: linux-wireless; +Cc: Reinette Chatre
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
Does it really have to be multi-threaded?
static void iwl_setup_deferred_work(struct iwl_priv *priv)
{
priv->workqueue = create_workqueue(DRV_NAME);
this creates one thread for each CPU, bound to that CPU, which seems
overkill. mac80211 even provides a single-threaded workqueue.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: iwlwifi workqueue
2008-10-15 21:47 iwlwifi workqueue Johannes Berg
@ 2008-10-16 1:58 ` Zhu Yi
0 siblings, 0 replies; 2+ messages in thread
From: Zhu Yi @ 2008-10-16 1:58 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, Chatre, Reinette
On Wed, 2008-10-15 at 14:47 -0700, Johannes Berg wrote:
> Does it really have to be multi-threaded?
No real reason. Actually most of the works are serialized by a mutex.
Patch is welcome.
Thanks,
-yi
> static void iwl_setup_deferred_work(struct iwl_priv *priv)
> {
> priv->workqueue = create_workqueue(DRV_NAME);
>
>
> this creates one thread for each CPU, bound to that CPU, which seems
> overkill. mac80211 even provides a single-threaded workqueue.
>
> johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-16 1:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-15 21:47 iwlwifi workqueue Johannes Berg
2008-10-16 1:58 ` Zhu Yi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).