Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Kalle Valo <kalle.valo@nokia.com>
Cc: John Linville <linville@tuxdriver.com>,
	Dan Williams <dcbw@redhat.com>, Jouni Malinen <j@w1.fi>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: inform userspace of probe/auth/assoc timeout
Date: Sun, 19 Oct 2008 12:16:35 +0200	[thread overview]
Message-ID: <1224411395.6324.36.camel@johannes.berg> (raw)
In-Reply-To: <873ait6s4e.fsf@nokia.com>

[-- Attachment #1: Type: text/plain, Size: 958 bytes --]

On Sun, 2008-10-19 at 09:01 +0300, Kalle Valo wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
> 
> > I noticed that when for some reason [1] the probe or auth times
> > out, wpa_supplicant doesn't realise this and only tries the next
> > AP when it runs into its own timeout, which is ten seconds, and
> > that's quite long. Fix this by making mac80211 notify userspace
> > that it didn't associate.
> 
> Earlier this week I received an internal bug report about this.
> Excellent timing for providing a fix. Thank you, Johannes :)

Heh :)

> > Might be worth backporting to stable?
> 
> I have to backport the patch anyway so I can provide the patch. But I
> don't think this being that important bug to be fixed in stable
> series. We have had this bug in mac80211 always, right?

I'm not entirely sure, I haven't dug through, it might have been
introduced only with one of the refactorings this code has seen.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2008-10-19 10:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-16 19:44 [PATCH] mac80211: inform userspace of probe/auth/assoc timeout Johannes Berg
2008-10-19  6:01 ` Kalle Valo
2008-10-19 10:16   ` Johannes Berg [this message]
2008-10-19 19:18   ` Kalle Valo
2008-10-19 21:35     ` Tomas Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224411395.6324.36.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=dcbw@redhat.com \
    --cc=j@w1.fi \
    --cc=kalle.valo@nokia.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox