From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
linux-wireless@vger.kernel.org, Luis.Rodriguez@atheros.com,
Jouni.Malinen@atheros.com, tomasw@gmail.com,
Sujith <Sujith.Manoharan@atheros.com>
Subject: Re: [PATCH v3] mac80211: Re-enable aggregation
Date: Thu, 23 Oct 2008 17:00:13 +0200 [thread overview]
Message-ID: <1224774013.6002.40.camel@johannes.berg> (raw)
In-Reply-To: <20081023145102.GA5816@tuxdriver.com>
[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]
On Thu, 2008-10-23 at 10:55 -0400, John W. Linville wrote:
> On Wed, Oct 22, 2008 at 08:10:42PM -0700, Luis R. Rodriguez wrote:
> > On Tue, Oct 21, 2008 at 1:27 AM, Sujith <Sujith.Manoharan@atheros.com> wrote:
> > > Wireless HW without any dedicated queues for aggregation
> > > do not need the ampdu_queues mechanism present right now
> > > in mac80211. Since mac80211 is still incomplete wrt TX MQ
> > > changes, do not allow aggregation sessions for drivers that
> > > set ampdu_queues.
> > >
> > > This is only an interim hack until Intel fixes the requeue issue.
> > >
> > > Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
> > > Signed-off-by: Luis Rodriguez <Luis.Rodriguez@Atheros.com>
> >
> > Poke.
>
> Just waiting to see comments from those who understand aggregation
> better than I do...
Who does? Code looks fine to me, but obviously it doesn't really solve
the problem, just adds workarounds for the current ath9k driver. Whether
you want that or not I'll leave up to you.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-10-23 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 8:27 [PATCH v3] mac80211: Re-enable aggregation Sujith
2008-10-23 3:10 ` Luis R. Rodriguez
2008-10-23 14:55 ` John W. Linville
2008-10-23 15:00 ` Johannes Berg [this message]
2008-10-23 16:52 ` Sujith
2008-10-23 17:33 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224774013.6002.40.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=Jouni.Malinen@atheros.com \
--cc=Luis.Rodriguez@atheros.com \
--cc=Sujith.Manoharan@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox