From: Johannes Berg <johannes@sipsolutions.net>
To: John Linville <linville@tuxdriver.com>
Cc: Tomas Winkler <tomasw@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: [PATCH] iwl3945: remove bogus comment
Date: Wed, 29 Oct 2008 01:02:27 +0100 [thread overview]
Message-ID: <1225238548.1369.10.camel@johannes.berg> (raw)
I added this comment myself, but it's clearly wrong. I had meant
to place it in iwl_mac_add_interface, which at the time didn't
honour the MAC address setting, but it does now.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
drivers/net/wireless/iwlwifi/iwl3945-base.c | 2 --
1 file changed, 2 deletions(-)
--- everything.orig/drivers/net/wireless/iwlwifi/iwl3945-base.c 2008-10-29 00:58:17.000000000 +0100
+++ everything/drivers/net/wireless/iwlwifi/iwl3945-base.c 2008-10-29 00:58:26.000000000 +0100
@@ -6742,8 +6742,6 @@ static int iwl3945_mac_config_interface(
return rc;
}
- /* XXX: this MUST use conf->mac_addr */
-
if (!iwl3945_is_alive(priv))
return -EAGAIN;
next reply other threads:[~2008-10-29 11:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 0:02 Johannes Berg [this message]
2008-10-29 17:29 ` [PATCH] iwl3945: remove bogus comment reinette chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225238548.1369.10.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox