Re: 2.6.28-rc regression: Can't stop Rx DMA

[reinette chatre <reinette.chatre@intel.com>]

On Tue, 2008-10-28 at 17:27 -0700, Dominik Brodowski wrote:
> With CONFIG_WIRELESS_OLD_REGULATORY=y, both the old and the new firmware
> works. Without, only the old firmware works.

(I assume you mean "only the new firmware works")

> 
> I'd think that at least the error message could be clarified a bit
> (is it really a "Microcode SW error"?)... also, it might be a corner case
> whether the new firmware would better be called -2 because of this
> incompatibility?

We can do away with the error message with a driver change. This patch
should take care of it:

diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
index 0758f8f..ab7c93d 100644
--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
@@ -6219,6 +6219,11 @@ static void iwl3945_bg_request_scan(struct work_struct *data)
 					      n_probes,
 			(void *)&scan->data[le16_to_cpu(scan->tx_cmd.len)]);
 
+	if (scan->channel_count == 0) {
+		IWL_DEBUG_SCAN("channel count %d\n", scan->channel_count);
+		goto done;
+	}
+
 	cmd.len += le16_to_cpu(scan->tx_cmd.len) +
 	    scan->channel_count * sizeof(struct iwl3945_scan_channel);
 	cmd.data = scan;