Re: [PATCH 08/10] ath9k: add block braces to match indentation

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]

On Thu, 2008-10-30 at 13:41 +0200, Ilpo Järvinen wrote:
> This isn't a behavior problem as is, and fixing indentation
> inconsistency either way would be fine (reindent or braces).
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
> ---
>  drivers/net/wireless/ath9k/main.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath9k/main.c b/drivers/net/wireless/ath9k/main.c
> index f05f584..0f67b1b 100644
> --- a/drivers/net/wireless/ath9k/main.c
> +++ b/drivers/net/wireless/ath9k/main.c
> @@ -467,9 +467,10 @@ void ath_tx_complete(struct ath_softc *sc, struct sk_buff *skb,
>  	if (tx_info->flags & IEEE80211_TX_CTL_NO_ACK ||
>  		tx_info->flags & IEEE80211_TX_STAT_TX_FILTERED) {
>  		/* free driver's private data area of tx_info */
> -		if (tx_info->driver_data[0] != NULL)
> +		if (tx_info->driver_data[0] != NULL) {
>  			kfree(tx_info->driver_data[0]);
>  			tx_info->driver_data[0] = NULL;
> +		}

Since kfree(NULL) is fine, how about just removing the if? Also, this
code has been removed in a recent change in the wireless tree, I think
(the rate control revamp)

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]