Re: [PATCH] mac80211_hwsim: enable Mesh Point operation

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1670 bytes --]

On Fri, 2008-10-31 at 23:23 -0700, Andrey Yurovsky wrote:
> Initial mesh support: add Mesh Point to supported interfaces mask and allow 
> hwsim to send beacons in mesh mode.

That'll do AP beacons, right? And it won't really help because all
virtual stations see each other?

> Signed-off-by: Andrey Yurovsky <andrey@cozybit.com>
> diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
> index 430d8b1..34f643f 100644
> --- a/drivers/net/wireless/mac80211_hwsim.c
> +++ b/drivers/net/wireless/mac80211_hwsim.c
> @@ -370,7 +370,8 @@ static void mac80211_hwsim_beacon_tx(void *arg, u8 *mac,
>  
>  	hwsim_check_magic(vif);
>  
> -	if (vif->type != NL80211_IFTYPE_AP)
> +	if (vif->type != NL80211_IFTYPE_AP && vif->type !=
> +			NL80211_IFTYPE_MESH_POINT)
>  		return;

I think I'd prefer if you'd write it as

if (vif->type != NL80211... &&
    vif->type != NL80211....)
	return;

but ultimately, I don't think it matters much. That above just looks a
little quirky, at least to me. :)

>  
>  	skb = ieee80211_beacon_get(hw, vif);
> @@ -777,7 +778,8 @@ static int __init init_mac80211_hwsim(void)
>  		hw->queues = 4;
>  		hw->wiphy->interface_modes =
>  			BIT(NL80211_IFTYPE_STATION) |
> -			BIT(NL80211_IFTYPE_AP);
> +			BIT(NL80211_IFTYPE_AP) |
> +			BIT(NL80211_IFTYPE_MESH_POINT);
>  		hw->ampdu_queues = 1;
>  
>  		/* ask mac80211 to reserve space for magic */
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]