From: Johannes Berg <johannes@sipsolutions.net>
To: David Miller <davem@davemloft.net>
Cc: marcel@holtmann.org, linux-wireless@vger.kernel.org
Subject: Re: Alignment issue with 4965 and 2.6.28-rc3
Date: Mon, 03 Nov 2008 08:39:37 +0100 [thread overview]
Message-ID: <1225697977.3619.28.camel@johannes.berg> (raw)
In-Reply-To: <20081102.233528.91273615.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 899 bytes --]
On Sun, 2008-11-02 at 23:35 -0800, David Miller wrote:
> From: Johannes Berg <johannes@sipsolutions.net>
> Date: Mon, 03 Nov 2008 08:25:00 +0100
>
> > I've tried sending a patch to add
> > CONFIG_HAVE_EFFICIENT_ALIGNED_ACCESS or something like that so that
> > we can fix it up if that is unset or make the driver depend on it,
> > but it hasn't stuck so far, so for now, ignore the warning and don't
> > try to use Intel wireless hw on platforms that don't like unaligned
> > loads.
>
> What are you smoking? ;-)
>
> arch/Kconfig:config HAVE_EFFICIENT_UNALIGNED_ACCESS
> arch/powerpc/Kconfig: select HAVE_EFFICIENT_UNALIGNED_ACCESS
> arch/x86/Kconfig: select HAVE_EFFICIENT_UNALIGNED_ACCESS
Woah, it _has_ stuck. And during .27 even, I totally missed that, not
sure why. Thanks for pointing it out, I'll go fix up alignment issues in
mac80211 then or something.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2008-11-03 7:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-03 0:13 Alignment issue with 4965 and 2.6.28-rc3 Marcel Holtmann
2008-11-03 7:25 ` Johannes Berg
2008-11-03 7:35 ` David Miller
2008-11-03 7:39 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225697977.3619.28.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox