From: reinette chatre <reinette.chatre@intel.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Bob Copeland <me@bobcopeland.com>,
Nick Kossifidis <mickflemm@gmail.com>,
"tim.gardner@canonical.com" <tim.gardner@canonical.com>,
"mick@madwifi.org" <mick@madwifi.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: wireless-testing commit eb9d4e8399181357cb6f6625ba7f849987432c6c causes stalls
Date: Mon, 03 Nov 2008 16:15:52 -0800 [thread overview]
Message-ID: <1225757752.1115.495.camel@rc-desk> (raw)
In-Reply-To: <43e72e890811030040r6b090f7ai4b8aa9fc55b4f78c@mail.gmail.com>
On Mon, 2008-11-03 at 00:40 -0800, Luis R. Rodriguez wrote:
> On Mon, Nov 3, 2008 at 12:30 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > On Mon, 2008-11-03 at 00:26 -0800, Luis R. Rodriguez wrote:
> >
> >> >> What should we do with these rare failures then?
> >> >
> >> > print an error message? ignore them? try again?
> >>
> >> I'd prefer a simple error print than a WARN_ON().
> >
> > Just so you don't get blamed on kerneloops.org? :)
>
> No because like I said a hw reset can fail and don't think software
> should be blamed. Right now we do that.
fyi ...
We also have to deal with this in iwlwifi now because the driver chooses
not to send commands to the hardware if rfkill is enabled. If this is
the case (command needs to go to hw, but rfkill is enabled) then we
currently return an error ... triggering this warning.
We cannot return success in this case and queuing the command for later
does not make sense.
Reinette
next prev parent reply other threads:[~2008-11-04 0:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 19:19 wireless-testing commit eb9d4e8399181357cb6f6625ba7f849987432c6c causes stalls Tim Gardner
2008-11-01 21:19 ` Luis R. Rodriguez
2008-11-02 8:32 ` Nick Kossifidis
2008-11-02 9:10 ` Nick Kossifidis
2008-11-02 18:41 ` Bob Copeland
2008-11-02 20:49 ` Luis R. Rodriguez
2008-11-03 7:18 ` Johannes Berg
2008-11-03 7:29 ` Luis R. Rodriguez
2008-11-03 7:34 ` Johannes Berg
2008-11-03 7:51 ` Luis R. Rodriguez
2008-11-03 7:54 ` Johannes Berg
2008-11-03 8:01 ` Luis R. Rodriguez
2008-11-03 8:04 ` Johannes Berg
2008-11-03 8:26 ` Luis R. Rodriguez
2008-11-03 8:30 ` Johannes Berg
2008-11-03 8:40 ` Luis R. Rodriguez
2008-11-04 0:15 ` reinette chatre [this message]
2008-11-03 14:42 ` Bob Copeland
2008-11-04 7:12 ` Kalle Valo
2008-11-04 8:38 ` Tomas Winkler
2008-11-02 20:40 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225757752.1115.495.camel@rc-desk \
--to=reinette.chatre@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=me@bobcopeland.com \
--cc=mick@madwifi.org \
--cc=mickflemm@gmail.com \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).