From: Pavel Roskin <proski@gnu.org>
To: Chr <chunkeey@web.de>
Cc: John W Linville <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] p54: don't report known but unhandled EEPROM codes as unknown
Date: Mon, 03 Nov 2008 19:35:07 -0500 [thread overview]
Message-ID: <1225758907.13275.14.camel@dv> (raw)
In-Reply-To: <200810301810.45647.chunkeey@web.de>
On Thu, 2008-10-30 at 18:10 +0100, Chr wrote:
> On Wednesday 29 October 2008 22:31:43 Pavel Roskin wrote:
> > [...]
> > + case PDR_RADIATED_TRANSMISSION_CORRECTION:
> > + case PDR_PRISM_TX_IQ_CALIBRATION:
> > + case PDR_BASEBAND_REGISTERS:
> > + case PDR_PER_CHANNEL_BASEBAND_REGISTERS:
> > + break;
> > default:
> > printk(KERN_INFO "p54: unknown eeprom code : 0x%x\n",
> > le16_to_cpu(entry->code));
>
> what about removing the printk?
> since intersil reserved 0x8000-0xffff for it's customers...
> so there could be lots of unknown pdr magics.
I don't see any extra messages. From my experience, OEMs don't change
anything except the required settings (IDs, OEM name, country code) and
don't add anything non-trivial.
But I'm fine either way, with or without that printk.
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2008-11-04 0:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 21:31 [PATCH] p54: don't report known but unhandled EEPROM codes as unknown Pavel Roskin
2008-10-30 16:50 ` Larry Finger
2008-10-30 17:10 ` Chr
2008-11-04 0:35 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225758907.13275.14.camel@dv \
--to=proski@gnu.org \
--cc=chunkeey@web.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).