From: Dan Williams <dcbw@redhat.com>
To: Alexey Fisher <bug-track@fisher-privat.net>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
rjw@sisk.pl, kernel-testers@vger.kernel.org
Subject: Re: [PATCH] make assocaittion only if SSID is known.
Date: Tue, 04 Nov 2008 17:47:08 -0500 [thread overview]
Message-ID: <1225838828.22671.0.camel@localhost.localdomain> (raw)
In-Reply-To: <1225836101-5723-1-git-send-email-bug-track@fisher-privat.net>
On Tue, 2008-11-04 at 23:01 +0100, Alexey Fisher wrote:
> 'iwconfig eth1 channel 6' would trigger association to _something_, which is wrong. Changing the channel should (and does) trigger reassociation, but only if there is an SSID to associate with!
Heh :) Need the Signed-off-by: here too though.
Dan
> drivers/net/wireless/ipw2200.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c
> index dcce354..d26beed 100644
> --- a/drivers/net/wireless/ipw2200.c
> +++ b/drivers/net/wireless/ipw2200.c
> @@ -7581,8 +7581,7 @@ static int ipw_associate(void *data)
> }
>
> if (!(priv->config & CFG_ASSOCIATE) &&
> - !(priv->config & (CFG_STATIC_ESSID |
> - CFG_STATIC_CHANNEL | CFG_STATIC_BSSID))) {
> + !(priv->config & (CFG_STATIC_ESSID | CFG_STATIC_BSSID))) {
> IPW_DEBUG_ASSOC("Not attempting association (associate=0)\n");
> return 0;
> }
next prev parent reply other threads:[~2008-11-04 22:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 22:01 [PATCH] make assocaittion only if SSID is known Alexey Fisher
2008-11-04 22:47 ` Dan Williams [this message]
2008-11-05 5:25 ` Kalle Valo
2008-11-05 8:59 ` Alexey Fisher
2008-11-05 10:20 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225838828.22671.0.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=bug-track@fisher-privat.net \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).