Re: [PATCH 1/2 2.6.28] iwlwifi : Fix channel scanning/association in 5Ghz band

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1440 bytes --]

On Thu, 2008-11-06 at 08:49 -0500, John W. Linville wrote:
> On Wed, Nov 05, 2008 at 11:17:22PM +0100, Marcel Holtmann wrote:
> 
> >> This patch is related to bug 11870 at bugzilla.kernel.org. With
> >> correct regulatory information the number of channels to scan
> >> will be correct and not zero as seen in that bug.
> >>
> >> This patch eliminates the need for wireless to be compiled with
> >> CONFIG_WIRELESS_OLD_REGULATORY to get correct regulatory behavior with
> >> iwlwifi.
> >
> > so this is still for 2.6.28, but for 2.6.29 and wireless-testing the API 
> > changed and we need a separate or different patch.
> >
> > John, Dave what is your take on pushing this to Linus this late in the  
> > merge window? I personally think we should do that. And if not, then  
> > change the Intel wireless Kconfig to select  
> > CONFIG_WIRELESS_OLD_REGULATORY by default at least.
> 
> CONFIG_WIRELESS_OLD_REGULATORY is already 'default y' now.  I don't
> really see why iwlwifi should _require_ that if someone decides to
> choose a non-default configuration.

I agree, also, I thought the problem was that iwlwifi misbehaved if
there were no active channels in the 5 GHz band and there was a patch to
fix that? This can happen _regardless_ of the setting of old regulatory,
it just happens that without the setting, the default is no 5 GHz
channels, while with it the default has 5 GHz channels.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]