Re: [PATCH 3/7] iwlwifi: fix priv->iw_mode setting when multiple vif are configured

[Zhu Yi <yi.zhu@intel.com>]

On Thu, 2008-11-06 at 18:39 +0800, Johannes Berg wrote:
> Ok, for one, it seems weird that you're saying you handled
>  * other bss
>  * allmulti
>  * bcn/presp promisc
>  * control
> without doing anything. Does your hw/fw really always pass up control
> frames? I didn't think it does.
> 
> Also, it seems rather odd that you need to reconnect etc. when a monitor
> interface is added, that would destroy AP and mesh modes completely when
> somebody adds a new monitor interface on AP mode to see what's going on.
> 
> Can you really not actually implement the filter flags but have to
> completely reprogram the firmware for monitor mode? What exactly does
> monitor mode do? It seems that at least, the logic in configure_filter
> should mask out the control/allmulti flags when otherbss is not set,
> because right now, if I add a monitor interface that _only_ asks for
> control frames and _not_ other bss frames, it doesn't look like it would
> work.

You are right. We don't need to reprogram the firmware completely to
support these filter flags. Will post a patch to reimplement our
configure_filter handler early next week.

Thanks,
-yi