Re: [PATCH 10/13] iwlwifi: move iwl_print_hex_dump to iwl-debug.h

[Harvey Harrison <harvey.harrison@gmail.com>]

On Fri, 2008-11-07 at 09:58 -0800, Reinette Chatre wrote:
> From: Winkler, Tomas <tomas.winkler@intel.com>
> 
> This patch moves iwl_print_hex_dump to iwl-debug.h
> where it belongs
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
> ---
>  drivers/net/wireless/iwlwifi/iwl-debug.h |   10 ++++++++++
>  drivers/net/wireless/iwlwifi/iwl-dev.h   |   17 -----------------
>  2 files changed, 10 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/net/wireless/iwlwifi/iwl-debug.h b/drivers/net/wireless/iwlwifi/iwl-debug.h
> index 84b7772..0e79a6a 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-debug.h
> +++ b/drivers/net/wireless/iwlwifi/iwl-debug.h
> @@ -40,6 +40,13 @@ do { if ((priv->debug_level & (level)) && net_ratelimit()) \
>    dev_printk(KERN_ERR, &(priv->hw->wiphy->dev), "%c %s " fmt, \
>  	 in_interrupt() ? 'I' : 'U', __func__ , ## args); } while (0)
>  
> +#define iwl_print_hex_dump(priv, level, p, len) 			\
> +do {                                            			\
> +	if (priv->debug_level & level)          			\
> +		print_hex_dump(KERN_DEBUG, "iwl data: ",		\
> +			       DUMP_PREFIX_OFFSET, 16, 1, p, len, 1);	\
> +} while (0)

static inline please.

> +
>  #ifdef CONFIG_IWLWIFI_DEBUGFS
>  struct iwl_debugfs {
>  	const char *name;
> @@ -70,6 +77,9 @@ void iwl_dbgfs_unregister(struct iwl_priv *priv);
>  #else
>  #define IWL_DEBUG(level, fmt, args...)
>  #define IWL_DEBUG_LIMIT(level, fmt, args...)
> +static inline void iwl_print_hex_dump(struct iwl_priv *priv, int level,
> +				      void *p, u32 len)
> +{}
>  #endif				/* CONFIG_IWLWIFI_DEBUG */

To keep it in sync with this.

Cheers,

Harvey