From: Harvey Harrison <harvey.harrison@gmail.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net, "Kolekar,
Abhijeet" <abhijeet.kolekar@intel.com>
Subject: Re: [PATCH 09/13] iwl3945 : Fix Sparse Warnings
Date: Fri, 07 Nov 2008 10:07:56 -0800 [thread overview]
Message-ID: <1226081276.11596.24.camel@brick> (raw)
In-Reply-To: <1226080726-24860-10-git-send-email-reinette.chatre@intel.com>
On Fri, 2008-11-07 at 09:58 -0800, Reinette Chatre wrote:
> From: Kolekar, Abhijeet <abhijeet.kolekar@intel.com>
>
> Patch fixes sparse warnings. No need to convert u8 variable
> to 32.
>
> Signed-off-by: Abhijeet Kolekar <abhijeet.kolekar@intel.com>
> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
> ---
It's customary to put the actual sparse warnings being fixed in the
commit message. In this case I assume it was this:
drivers/net/wireless/iwlwifi/iwl3945-base.c:4838:18: warning: invalid assignment: |=
drivers/net/wireless/iwlwifi/iwl3945-base.c:4838:18: left side has type unsigned char
drivers/net/wireless/iwlwifi/iwl3945-base.c:4838:18: right side has type restricted __le32
Anyways, looks fine.
Cheers,
Harvey
next prev parent reply other threads:[~2008-11-07 18:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 17:58 [PATCH 0/13] iwlwifi driver updates Reinette Chatre
2008-11-07 17:58 ` [PATCH 01/13] iwlagn: fix resume for ADHOC network Reinette Chatre
2008-11-07 17:58 ` [PATCH 02/13] iwl3945: " Reinette Chatre
2008-11-07 17:58 ` [PATCH 03/13] iwlwifi: trivial fix in includes Reinette Chatre
2008-11-07 17:58 ` [PATCH 04/13] iwlwifi: don't fail power set when calibration is not done yet Reinette Chatre
2008-11-07 17:58 ` [PATCH 05/13] iwlwifi: update iwl-commands.h for 3 stream support Reinette Chatre
2008-11-07 17:58 ` [PATCH 06/13] iwlwifi: move rx queue read pointer into rxq Reinette Chatre
2008-11-07 17:58 ` [PATCH 07/13] iwlwifi: revamp tx scheduler byte count tables handling Reinette Chatre
2008-11-07 17:58 ` [PATCH 08/13] iwlwifi: move spectrum measurement code to iwl-spectrum.c file Reinette Chatre
2008-11-07 17:58 ` [PATCH 09/13] iwl3945 : Fix Sparse Warnings Reinette Chatre
2008-11-07 17:58 ` [PATCH 10/13] iwlwifi: move iwl_print_hex_dump to iwl-debug.h Reinette Chatre
2008-11-07 17:58 ` [PATCH 11/13] iwl3945 : Simplify iwl3945_send_beacon_cmd Reinette Chatre
2008-11-07 17:58 ` [PATCH 12/13] iwlwifi: get some more information about command failure Reinette Chatre
2008-11-07 17:58 ` [PATCH 13/13] iwlwifi: use Rx single frame mode (one Rx frame per RB) Reinette Chatre
2008-11-07 18:09 ` [PATCH 11/13] iwl3945 : Simplify iwl3945_send_beacon_cmd Harvey Harrison
2008-11-07 20:10 ` reinette chatre
2008-11-07 18:03 ` [PATCH 10/13] iwlwifi: move iwl_print_hex_dump to iwl-debug.h Harvey Harrison
2008-11-08 19:11 ` Tomas Winkler
2008-11-07 18:07 ` Harvey Harrison [this message]
2008-11-07 18:18 ` [PATCH 09/13] iwl3945 : Fix Sparse Warnings reinette chatre
2008-11-08 5:51 ` [PATCH 05/13] iwlwifi: update iwl-commands.h for 3 stream support Marcel Holtmann
2008-11-11 16:54 ` reinette chatre
2008-11-07 20:58 ` [PATCH 01/13] iwlagn: fix resume for ADHOC network Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226081276.11596.24.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=abhijeet.kolekar@intel.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).