Re: [PATCH 11/13] iwl3945 : Simplify iwl3945_send_beacon_cmd

[Harvey Harrison <harvey.harrison@gmail.com>]

On Fri, 2008-11-07 at 09:58 -0800, Reinette Chatre wrote:
> From: Kolekar, Abhijeet <abhijeet.kolekar@intel.com>
> 
> Moved rate_msk calculation to iwl3945_rate_get_lowest_plcp.
> 
> Signed-off-by: Abhijeet Kolekar <abhijeet.kolekar@intel.com>
> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
> ---
>  drivers/net/wireless/iwlwifi/iwl3945-base.c |   26 ++++++++++++++------------
>  1 files changed, 14 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> index 51f1c81..dec9e04 100644
> --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
> +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> @@ -1420,9 +1420,16 @@ unsigned int iwl3945_fill_beacon_frame(struct iwl3945_priv *priv,
>  	return priv->ibss_beacon->len;
>  }
>  
> -static u8 iwl3945_rate_get_lowest_plcp(int rate_mask)
> +static u8 iwl3945_rate_get_lowest_plcp(struct iwl3945_priv *priv)
>  {
>  	u8 i;
> +	int rate_mask;
> +
> +	/* Set rate mask*/
> +	if (priv->staging_rxon.flags & RXON_FLG_BAND_24G_MSK)
> +		rate_mask = priv->active_rate_basic & 0xF;
> +	else
> +		rate_mask = priv->active_rate_basic & 0xFF0;

Perhaps a helpful define for these two magic mask values is called for.


Cheers,

Harvey