From: Johannes Berg <johannes@sipsolutions.net>
To: Kalle Valo <kalle.valo@nokia.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 2/2] mac80211: implement dynamic power save
Date: Mon, 10 Nov 2008 10:36:48 +0100 [thread overview]
Message-ID: <1226309808.4004.16.camel@johannes.berg> (raw)
In-Reply-To: <1226245439-30329-3-git-send-email-kalle.valo@nokia.com> (sfid-20081109_164424_115149_4F11A949)
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
On Sun, 2008-11-09 at 17:43 +0200, Kalle Valo wrote:
> bool powersave;
> + int dynamic_ps_timeout;
> + struct work_struct ps_enable_work;
> + struct work_struct ps_disable_work;
> + struct timer_list dynamic_ps_timer;
I think you could use a delayed work for the enable-work+timer, that
combines them already.
Looks good to me.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-11-10 9:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-09 15:43 [RFC] mac80211 dynamic powersave Kalle Valo
2008-11-09 15:43 ` [RFC 1/2] mac80211: enable IEEE80211_CONF_PS only when associated Kalle Valo
2008-11-10 9:28 ` Johannes Berg
2008-11-10 9:36 ` Kalle Valo
2008-11-09 15:43 ` [RFC 2/2] mac80211: implement dynamic power save Kalle Valo
2008-11-10 9:36 ` Johannes Berg [this message]
2008-11-10 9:49 ` Kalle Valo
2008-11-10 9:53 ` Johannes Berg
2008-11-10 20:14 ` Luis R. Rodriguez
2008-11-11 7:14 ` Kalle Valo
2008-11-11 10:18 ` Vivek Natarajan
2008-11-11 13:09 ` Kalle Valo
2008-11-11 16:40 ` Nick Kossifidis
2008-11-11 4:32 ` [RFC] mac80211 dynamic powersave Vivek Natarajan
2008-11-11 10:38 ` Johannes Berg
2008-11-12 6:17 ` Vivek Natarajan
2008-11-12 17:33 ` Luis R. Rodriguez
[not found] ` <8e92b4100811102018q4a13568l625abf2c59dca253@mail.gmail.com>
2008-11-11 12:29 ` Kalle Valo
2008-11-11 12:57 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226309808.4004.16.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=kalle.valo@nokia.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).