From: Johannes Berg <johannes@sipsolutions.net>
To: Tomas Winkler <tomasw@gmail.com>
Cc: "John Linville" <linville@tuxdriver.com>,
"reinette chatre" <reinette.chatre@intel.com>,
"Marcel Holtmann" <marcel@holtmann.org>,
"Luis R. Rodriguez" <mcgrof@gmail.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"Matt Mackall" <mpm@selenic.com>,
"Christophe Dumez" <dchris@gmail.com>,
"Zhu Yi" <yi.zhu@intel.com>, "Jan Včelák" <vcelak.jan@seznam.cz>,
"Thomas Witt" <witt_th@gmx.de>,
linux-wireless <linux-wireless@vger.kernel.org>,
"Andres Freund" <andres@anarazel.de>
Subject: Re: [PATCH/RFT] iwlagn: fix RX skb alignment
Date: Wed, 19 Nov 2008 14:14:56 +0100 [thread overview]
Message-ID: <1227100496.26243.40.camel@johannes.berg> (raw)
In-Reply-To: <1227100347.26243.38.camel@johannes.berg> (sfid-20081119_141314_720850_5E82DA6A)
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
On Wed, 2008-11-19 at 14:12 +0100, Johannes Berg wrote:
> On Wed, 2008-11-19 at 14:09 +0100, Johannes Berg wrote:
> > On Wed, 2008-11-19 at 15:02 +0200, Tomas Winkler wrote:
> >
> > > > Here's a thought: iwl_rx_queue_update_write_ptr doesn't synchronise the
> > > > pointer rxq->bd memory to the device. So if you have a platform that's
> > > > not cache coherent for IO devices (mine is) that might be a problem.
> > >
> > > Need to issue wmb() there or something like this?
> >
> > well rb is also dma memory, no? So you'd have to use dma_sync_ or
> > something, just like with skb data, no?
>
> or maybe not? I can't look into this today, sorry.
Ah, no, you don't have to because this is allocated with
pci_alloc_consistent. I'm getting confused, sorry.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-11-19 13:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 0:47 [PATCH/RFT] iwlagn: fix RX skb alignment Johannes Berg
2008-11-18 1:57 ` Zhu Yi
2008-11-18 2:05 ` Johannes Berg
2008-11-18 9:43 ` Johannes Berg
2008-11-18 14:13 ` Tomas Winkler
2008-11-18 15:25 ` Johannes Berg
2008-11-19 9:15 ` Tomas Winkler
2008-11-19 11:36 ` Johannes Berg
2008-11-19 12:22 ` Tomas Winkler
2008-11-19 12:33 ` Johannes Berg
2008-11-19 13:02 ` Tomas Winkler
2008-11-19 13:09 ` Johannes Berg
2008-11-19 13:12 ` Johannes Berg
2008-11-19 13:14 ` Johannes Berg [this message]
2008-11-19 0:48 ` Johannes Berg
2008-11-19 9:21 ` Tomas Winkler
2008-11-19 11:40 ` Johannes Berg
2008-11-19 12:24 ` Tomas Winkler
2008-11-19 12:28 ` Johannes Berg
2008-11-19 13:00 ` Tomas Winkler
2008-11-18 10:52 ` Johannes Berg
2008-11-18 23:20 ` Luis R. Rodriguez
2008-11-19 0:22 ` [PATCH] iwlagn: fix DMA sync Johannes Berg
2008-11-18 10:56 ` [PATCH/RFT] iwlagn: fix RX skb alignment Johannes Berg
2008-11-18 16:38 ` Thomas Witt
2008-11-19 1:58 ` Zhu Yi
2008-12-01 17:30 ` reinette chatre
2008-12-01 19:37 ` Johannes Berg
2008-12-01 23:30 ` reinette chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227100496.26243.40.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=andres@anarazel.de \
--cc=dchris@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=marcel@holtmann.org \
--cc=mcgrof@gmail.com \
--cc=mpm@selenic.com \
--cc=reinette.chatre@intel.com \
--cc=rjw@sisk.pl \
--cc=tomasw@gmail.com \
--cc=vcelak.jan@seznam.cz \
--cc=witt_th@gmx.de \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).