Re: [PATCH] orinoco: indicate it is using dBm in wireless_stats and spy

[Pavel Roskin <proski@gnu.org>]

On Sat, 2008-11-15 at 17:15 +0300, Andrey Borzenkov wrote:
> Subject: [PATCH] orinoco: indicate it is using dBm in wireless_stats and spy
> From: Andrey Borzenkov <arvidjaar@mail.ru>
> 
> Since WE7 /proc/net/wireless checks whether level and noise  are in dBm
> and shows them accordingly. Indicate that we return signal and noice
> levels in dBm.

I believe the formula we are using is not exact.  Intersil firmware has
a separate register (HERMES_RID_DBMCOMMSQUALITY_INTERSIL) that provides
the dBm data.  It relates to the data we are using
(HERMES_RID_COMMSQUALITY) in a linear way, but the multiplier is not 1.
I remember I tried to recover the formula but didn't have time to
complete it.  Besides, different brands and version of the firmware do
it differently.

Anyway, we are using the same formula everywhere, yet we are
inconsistent.  In some places the code uses IW_QUAL_DBM, in some places
is doesn't.  It's better to be consistent.  We can improve the formula
later.  The numbers are in the reasonable range.

> Signed-off-by: Andrey Borzenkov <arvidjaar@mail.ru>

(with some hesitation)
Signed-off-by: Pavel Roskin <proski@gnu.org>

-- 
Regards,
Pavel Roskin