Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ivan Kuten <ivan.kuten@promwad.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: ieee80211_wep_encrypt_data_fix_unaligned_access.patch
Date: Sat, 22 Nov 2008 18:18:26 +0100	[thread overview]
Message-ID: <1227374306.3599.12.camel@johannes.berg> (raw)
In-Reply-To: <eaf88bcfcb5b61c24cf1b8b682c5ff3c@promwad.com> (sfid-20081121_234653_121082_4B762D50)

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

On Sat, 2008-11-22 at 00:46 +0200, Ivan Kuten wrote:

> -       icv = (__le32 *)(data + data_len);
> -       *icv = cpu_to_le32(~crc32_le(~0, data, data_len));
> +       icv = cpu_to_le32(~crc32_le(~0, data, data_len));
> +       put_unaligned(icv, (__le32 *)(data + data_len));

Aren't you putting a pointer now??

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2008-11-22 17:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-21 22:46 ieee80211_wep_encrypt_data_fix_unaligned_access.patch Ivan Kuten
2008-11-22 17:18 ` Johannes Berg [this message]
2008-11-22 17:58   ` ieee80211_wep_encrypt_data_fix_unaligned_access.patch Johannes Berg
2008-11-22 17:59 ` ieee80211_wep_encrypt_data_fix_unaligned_access.patch Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1227374306.3599.12.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=ivan.kuten@promwad.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox