From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <j@w1.fi>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] nl80211: Add frequency configuration (including HT40)
Date: Tue, 25 Nov 2008 20:13:04 +0100 [thread overview]
Message-ID: <1227640384.4613.44.camel@johannes.berg> (raw)
In-Reply-To: <20081125190533.GA27879@jm.kir.nu>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On Tue, 2008-11-25 at 21:05 +0200, Jouni Malinen wrote:
> + if (info->attrs[NL80211_ATTR_WIPHY_FREQ]) {
> + int sec_chan_offset = 0;
> +
> + if (!rdev->ops->set_channel) {
> + result = -EOPNOTSUPP;
> + goto bad_res;
> + }
> +
> + if (info->attrs[NL80211_ATTR_WIPHY_SEC_CHAN_OFFSET]) {
> + u8 val = nla_get_u8(
> + info->attrs[
> + NL80211_ATTR_WIPHY_SEC_CHAN_OFFSET]);
> + if (val == NL80211_SEC_CHAN_BELOW)
> + sec_chan_offset = -1;
> + else if (val == NL80211_SEC_CHAN_ABOVE)
> + sec_chan_offset = 1;
> + }
> + result = rdev->ops->set_channel(
> + &rdev->wiphy,
> + nla_get_u32(info->attrs[NL80211_ATTR_WIPHY_FREQ]),
> + sec_chan_offset);
Isn't that missing regulatory enforcement? I'd rather see that in
cfg80211 than re-implemented in all drivers.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-11-25 19:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 19:05 [RFC] nl80211: Add frequency configuration (including HT40) Jouni Malinen
2008-11-25 19:13 ` Johannes Berg [this message]
2008-11-26 7:52 ` Jouni Malinen
2008-11-26 4:51 ` Sujith
2008-11-26 7:55 ` Jouni Malinen
2008-11-26 8:05 ` Sujith
2008-11-26 8:40 ` Johannes Berg
2008-11-26 9:51 ` Sujith
2008-11-26 8:38 ` Jouni Malinen
2008-11-26 11:04 ` Johannes Berg
2008-11-26 13:14 ` Jouni Malinen
2008-11-26 13:38 ` Jouni Malinen
2008-11-26 13:55 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227640384.4613.44.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox