linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <holtmann@linux.intel.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Helmut Schaa <helmut.schaa@googlemail.com>,
	Tomas Winkler <tomasw@gmail.com>,
	linux-wireless@vger.kernel.org, yi.zhu@intel.com
Subject: Re: iwlwifi - rfkill only works if the interface is up
Date: Tue, 02 Dec 2008 14:14:53 +0100	[thread overview]
Message-ID: <1228223693.31158.240.camel@violet.holtmann.net> (raw)
In-Reply-To: <20081202125959.GC1668@khazad-dum.debian.net>

Hi Henrique,

> > if the hardware/firmware doesn't allow us to do so, we have no real
> > option. I think that nobody thought about this use case so far. I am not
> > sure if we should unregister it or just fix rfkill to add an invalid
> > state. It is also possible to tie rfkill with ifup/ifdown.
> 
> Please don't register/unregister rfkill classes like that, it is extremely
> broken from userspace's point-of-view, and it is not how the rfkill core
> subsystem expects things to be used either.    If there is no way to avoid
> register/unregister at interface up/down, it is better to never register any
> rfkill classes at all, and remove the functionality.
> 
> Now, I hate when people use the term "rfkill switch" when dealing with the
> kernel rfkill subsystem, because we can't really always be sure we
> understood what the person means, so please bear with me...
> 
> Are you talking about the hardware rfkill line (the input pin where one
> might have hooked an input device)?  Or about something else?

so this case is that we are not getting any updates about the rfkill
line status if the firmware is not loaded (happens at ifdown case). How
do you propose this should be handled?

Regards

Marcel



  reply	other threads:[~2008-12-02 13:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-01 12:11 iwlwifi - rfkill only works if the interface is up Helmut Schaa
2008-12-01 13:08 ` Tomas Winkler
2008-12-01 15:04   ` Helmut Schaa
2008-12-01 17:43     ` Tomas Winkler
2009-01-05 14:43       ` Helmut Schaa
2008-12-01 15:30   ` Marcel Holtmann
2008-12-01 15:34     ` Helmut Schaa
2008-12-01 15:59       ` Marcel Holtmann
2008-12-01 16:16         ` Helmut Schaa
2008-12-01 21:12         ` John W. Linville
2008-12-01 21:50           ` Helmut Schaa
2008-12-03 22:48             ` Dan Williams
2008-12-02 12:59         ` Henrique de Moraes Holschuh
2008-12-02 13:14           ` Marcel Holtmann [this message]
2008-12-02 15:03             ` Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1228223693.31158.240.camel@violet.holtmann.net \
    --to=holtmann@linux.intel.com \
    --cc=helmut.schaa@googlemail.com \
    --cc=hmh@hmh.eng.br \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tomasw@gmail.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).