From: reinette chatre <reinette.chatre@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
Tomas Winkler <tomasw@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] iwlwifi: disable AP mode
Date: Tue, 02 Dec 2008 08:48:49 -0800 [thread overview]
Message-ID: <1228236529.10900.46.camel@rc-desk> (raw)
In-Reply-To: <1228153827.10627.25.camel@johannes.berg>
On Mon, 2008-12-01 at 09:50 -0800, Johannes Berg wrote:
> iwlwifi does not support AP mode in any way. For one, it doesn't even
> buffer multicast/broadcast frames properly. We didn't allow zd1211rw AP
> mode to be enabled without this, so iwlwifi shouldn't be allowed to
> advertise AP mode either.
>
> It also doesn't work at all, it doesn't even answer to probe requests,
> I'm guessing the packet injection code was disabled again.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> FYI, I've also tested AP mode on iwl5000 and it most definitely does not
> work properly:
>
> [ 471.524478] iwlagn: ERROR: APs don't scan
>
> this is a long-standing bug, of course APs scan to know their
> surroundings, not sure why this is there, it's also very pointless since
> I can remove it by enabling software scan...
>
> [ 487.507346] iwlagn: Microcode SW error detected. Restarting 0x2000000.
>
> apparently even the microcode doesn't like AP mode :) Note that I've
> done nothing out of the ordinary, just started hostapd.
>
> Once somebody cares to fix the code these two lines can be put back
> easily, I haven't ripped out the actual support code. But when you do
> please test with PS clients and multicast traffic.
>
> drivers/net/wireless/iwlwifi/iwl-core.c | 1 -
> drivers/net/wireless/iwlwifi/iwl3945-base.c | 1 -
> 2 files changed, 2 deletions(-)
>
Acked-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
prev parent reply other threads:[~2008-12-02 16:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 17:50 [PATCH] iwlwifi: disable AP mode Johannes Berg
2008-12-02 16:48 ` reinette chatre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228236529.10900.46.camel@rc-desk \
--to=reinette.chatre@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox