From: Johannes Berg <johannes@sipsolutions.net>
To: reinette chatre <reinette.chatre@intel.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] mac80211: remove WARN_ON() from ieee80211_hw_config
Date: Thu, 04 Dec 2008 23:29:20 +0100 [thread overview]
Message-ID: <1228429761.5692.54.camel@johannes.berg> (raw)
In-Reply-To: <1228429462.28477.77.camel@rc-desk>
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
On Thu, 2008-12-04 at 14:24 -0800, reinette chatre wrote:
> > I suppose the probability of the beacon interval changing is rather low,
> > but should we propagate the error in that case rather than just using
> > -EINVAL?
>
> I do not understand. By returning -EINVAL the error is propagated up to
> nl80211 from where the call came.
Ah, but the error code is lost, the driver might have returned -EBUSY or
something. I'm not sure we want to pass that up, it might be better not
to, not sure.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-12-04 22:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 21:25 [RFC] mac80211: remove WARN_ON() from ieee80211_hw_config Reinette Chatre
2008-12-04 21:57 ` Johannes Berg
2008-12-04 22:24 ` reinette chatre
2008-12-04 22:29 ` Johannes Berg [this message]
2008-12-04 22:40 ` reinette chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228429761.5692.54.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox