From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <j@w1.fi>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Sujith Manoharan <Sujith.Manoharan@atheros.com>
Subject: Re: [PATCH] ath9k: remove fragmentation workaround again
Date: Tue, 09 Dec 2008 17:51:25 +0100 [thread overview]
Message-ID: <1228841485.1029.16.camel@johannes.berg> (raw)
In-Reply-To: <20081209163939.GA7947@jm.kir.nu>
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
On Tue, 2008-12-09 at 18:39 +0200, Jouni Malinen wrote:
> On Tue, Dec 09, 2008 at 12:26:14PM +0100, Johannes Berg wrote:
> > Looking at the RC algorithm this is no longer necessary.
>
> > Untested, but the error that used to happen will no longer happen since
> > now the sub-structure is assigned by the driver, in rate_driver_data,
> > per fragment.
>
> Thanks! Based on a quick test, fragmentation was working with this
> patch. I never tested the old issue, so I'm not sure what exactly was
> failing, but anyway, I do see fragments in a sniffer log and the device
> did not crash ;-).
Heh, well, the broken rc algorithm would end up with a double-free and
slub/slab/slob being very unhappy.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2008-12-09 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 11:26 [PATCH] ath9k: remove fragmentation workaround again Johannes Berg
2008-12-09 16:39 ` Jouni Malinen
2008-12-09 16:51 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228841485.1029.16.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=Sujith.Manoharan@atheros.com \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox