From: Johannes Berg <johannes@sipsolutions.net>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
John Linville <linville@tuxdriver.com>,
Dan E <trg_info@mailhaven.com>
Subject: Re: [PATCH] mac80211: remove fragmentation offload functionality
Date: Tue, 09 Dec 2008 22:10:09 +0100 [thread overview]
Message-ID: <1228857009.1029.18.camel@johannes.berg> (raw)
In-Reply-To: <200812092136.56768.IvDoorn@gmail.com> (sfid-20081209_213730_750098_CD905347)
[-- Attachment #1: Type: text/plain, Size: 855 bytes --]
On Tue, 2008-12-09 at 21:36 +0100, Ivo van Doorn wrote:
> On Tuesday 09 December 2008, Johannes Berg wrote:
> > There's no driver that actually does fragmentation on the
> > device, and the callback is buggy (when it returns an error,
> > mac80211's fragmentation status is changed so reading the
> > frag threshold from userspace reads the new value despite
> > the error). Let's just remove it, if we really find some
> > hardware supporting it we can add it back later.
> >
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> > ---
> > Unless anybody knows a work-in-progress driver that needs this, in which
> > case we should fix it? Speak up now if you do.
>
> For rt2800{pci,usb} the set_frag_threshold is not implemented, so it won't
> provide problems with those drivers.
That's why I asked, thanks :)
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2008-12-09 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 11:30 [PATCH] mac80211: remove fragmentation offload functionality Johannes Berg
2008-12-09 20:36 ` Ivo van Doorn
2008-12-09 21:10 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228857009.1029.18.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=trg_info@mailhaven.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox