From: Dan Williams <dcbw@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
Michael Buesch <mb@bu3sch.de>,
Marcel Holtmann <marcel@holtmann.org>,
linux-wireless@vger.kernel.org, bcm43xx-dev@lists.berlios.de,
hmh@hmh.eng.br
Subject: Re: [RFC] b43: rework rfkill code
Date: Wed, 10 Dec 2008 13:59:05 -0500 [thread overview]
Message-ID: <1228935546.28590.37.camel@localhost.localdomain> (raw)
In-Reply-To: <1228934039.15837.59.camel@johannes.berg>
On Wed, 2008-12-10 at 19:33 +0100, Johannes Berg wrote:
> On Wed, 2008-12-10 at 13:29 -0500, Dan Williams wrote:
>
> > > Does the wireless driver get the notification about this from the
> > > hardware, like it would if this was a real physical switch? Then it's
> > > probably pretty simple: provide a rfkill struct from the driver that
> > > updates hard-kill and provide a second rfkill struct for the platform
> > > device that doesn't get hard-killed, but also provide a soft-kill input
> > > form the platform device. That way, you can toggle that button, but you
> > > can also software-enable the platform rfkill device and that in turn
> > > re-enables the wifi-rfkill "hw" switch device.
> >
> > This sort of sucks for userspace, because we see the actual wifi card as
> > hardblocked, but some other random button as softblocked. There's no
> > indication that changing the softblock one will affect the hardblocked
> > one. What are userspace processes supposed to do here, assume that if a
> > non-radio-associated softblocked switch exists, that it can re-enable a
> > hardblocked radio of some random wifi card?
>
> The other question is whether we actually care? So what if the hardware
> can only be enabled with the button, why does that matter?
I guess it doesn't, as long as in Matthew's case, the actual radio
rfkill state is only ever softblocked, because it actually *can* be
re-enabled with the platform button or something.
Dan
next prev parent reply other threads:[~2008-12-10 19:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 15:09 [RFC] b43: rework rfkill code Matthew Garrett
2008-12-10 15:29 ` Johannes Berg
2008-12-10 16:15 ` Ivo van Doorn
2008-12-10 16:51 ` Marcel Holtmann
2008-12-10 17:18 ` Johannes Berg
2008-12-10 17:23 ` Johannes Berg
2008-12-10 17:28 ` Johannes Berg
2008-12-10 21:33 ` Henrique de Moraes Holschuh
2008-12-10 21:42 ` Michael Buesch
2008-12-10 17:31 ` Michael Buesch
2008-12-10 17:37 ` Johannes Berg
2008-12-10 17:51 ` Matthew Garrett
2008-12-10 18:04 ` Michael Buesch
2008-12-10 18:05 ` Johannes Berg
2008-12-10 18:09 ` Matthew Garrett
2008-12-10 18:29 ` Dan Williams
2008-12-10 18:33 ` Johannes Berg
2008-12-10 18:59 ` Dan Williams [this message]
2008-12-10 20:07 ` Michael Buesch
2009-03-29 18:19 ` Johannes Berg
2008-12-11 0:32 ` Julian Calaby
2008-12-11 1:27 ` Michael Buesch
2008-12-11 13:28 ` Kalle Valo
2008-12-10 15:48 ` Michael Buesch
2008-12-10 16:12 ` Matthew Garrett
2008-12-11 16:55 ` Larry Finger
2008-12-12 4:28 ` Larry Finger
2008-12-17 15:48 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228935546.28590.37.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=hmh@hmh.eng.br \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mb@bu3sch.de \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox