From: Johannes Berg <johannes@sipsolutions.net>
To: Rami Rosen <ramirose@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Vladimir Koutny <vlado@ksp.sk>
Subject: Re: [PATCH 1/2] mac80211: misc cleanups
Date: Thu, 11 Dec 2008 15:28:23 +0100 [thread overview]
Message-ID: <1229005703.8081.12.camel@johannes.berg> (raw)
In-Reply-To: <eb3ff54b0812110400y2305c5abp9955a325b3372215@mail.gmail.com> (sfid-20081211_130026_587546_9D11E66D)
[-- Attachment #1: Type: text/plain, Size: 615 bytes --]
On Thu, 2008-12-11 at 14:00 +0200, Rami Rosen wrote:
> - rx->sta = ieee80211_ibss_add_sta(sdata, rx->skb,
> - bssid, hdr->addr2,
> - BIT(rx->status->rate_idx));
> + rx->sta = ieee80211_ibss_add_sta(sdata, bssid, hdr->addr2,
> + BIT(rx->status->rate_idx));
Unrelated to this patch (it's good), shouldn't we take into account the
mandatory rate set here? If, for instance, we're receiving an 11MBit
frame then we can be sure the sender supports 1 and 11, and if we're
receiving a 48 MBit frame then we know already it supports [1, 2, 5.5,
11 if 2.4 GHz], 6, 12, 24 and 48.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2008-12-11 17:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 12:00 [PATCH 1/2] mac80211: misc cleanups Rami Rosen
2008-12-11 14:28 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229005703.8081.12.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=ramirose@gmail.com \
--cc=vlado@ksp.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox