From: Harvey Harrison <harvey.harrison@gmail.com>
To: Benoit PAPILLAULT <benoit.papillault@free.fr>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ath5k-devel@lists.ath5k.org
Subject: Re: [PATCH] ath5k : Fix correct padding
Date: Thu, 11 Dec 2008 14:08:18 -0800 [thread overview]
Message-ID: <1229033298.15776.18.camel@brick> (raw)
In-Reply-To: <49418D23.8060905@free.fr>
On Thu, 2008-12-11 at 22:58 +0100, Benoit PAPILLAULT wrote:
> Padding the 802.11 header to a multiple of 4 bytes needs to be done only
> for DATA frames. This fixes a bug where 2 bytes were missing in monitor
> mode for ACK frames.
Without commenting on whether or not this is needed
> /*
> @@ -2623,6 +2629,7 @@ ath5k_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
> unsigned long flags;
> int hdrlen;
> int pad;
> + const struct ieee80211_hdr * hdr = (const struct ieee80211_hdr *)skb;
skb->data perhaps.
Harvey
next prev parent reply other threads:[~2008-12-11 22:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 21:58 [PATCH] ath5k : Fix correct padding Benoit PAPILLAULT
2008-12-11 21:58 ` Michael Buesch
2008-12-11 22:05 ` Johannes Berg
2008-12-11 22:07 ` Johannes Berg
2008-12-11 22:50 ` [ath5k-devel] " Bob Copeland
2008-12-11 22:08 ` Harvey Harrison [this message]
2008-12-11 22:10 ` Johannes Berg
2008-12-12 8:49 ` Benoit PAPILLAULT
2008-12-12 15:38 ` [ath5k-devel] " Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229033298.15776.18.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=benoit.papillault@free.fr \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).