From: Johannes Berg <johannes@sipsolutions.net>
To: "Stefanik Gábor" <netrolller.3d@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC 2/3] mac80211: Make use of the new F_TX_NOACK and F_TX_NOSEQ Radiotap TX flags
Date: Fri, 12 Dec 2008 23:45:47 +0100 [thread overview]
Message-ID: <1229121947.3565.13.camel@johannes.berg> (raw)
In-Reply-To: <69e28c910812121443h1fae52e6uc88749d7e9baf529@mail.gmail.com> (sfid-20081212_234356_997724_240E2F15)
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
On Fri, 2008-12-12 at 23:43 +0100, Stefanik Gábor wrote:
> I tried, but for some reason setting IEEE80211_TX_CTL_NO_ACK directly
> in __ieee80211_parse_tx_radiotap resulted in an oops upon unloading
> the driver module.
Huh? That doesn't make sense. Do you have more information on that?
> Note that IEEE80211_TX_MON_NO_ACK is not equivalent to
> !(IEEE80211_TX_CTL_ASSIGN_SEQ), as it also disables mac80211's built
> in sequence numbering.
Ah. But there's precedence for just doing
if (unlikely(!(info->flags & ASSIGN_SEQ)))
return;
in the handler that assigns the seq, and I prefer that over adding a new
flag.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-12-12 22:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-12 22:32 [RFC 2/3] mac80211: Make use of the new F_TX_NOACK and F_TX_NOSEQ Radiotap TX flags Stefanik Gábor
2008-12-12 22:39 ` Johannes Berg
2008-12-12 22:43 ` Stefanik Gábor
2008-12-12 22:45 ` Johannes Berg [this message]
2008-12-12 22:51 ` Stefanik Gábor
2008-12-12 22:52 ` Johannes Berg
2008-12-12 23:00 ` Stefanik Gábor
2008-12-12 23:01 ` Johannes Berg
2008-12-12 22:56 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229121947.3565.13.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netrolller.3d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox