linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: "Stefanik Gábor" <netrolller.3d@gmail.com>
Cc: Bob Copeland <me@bobcopeland.com>,
	maximlevitsky@gmail.com, ath5k-devel@venema.h4ckr.net,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath5k: set mac address in add_interface
Date: Mon, 15 Dec 2008 11:22:32 -0500	[thread overview]
Message-ID: <1229358152.12163.64.camel@localhost.localdomain> (raw)
In-Reply-To: <69e28c910812150812h4a316327u67aad1b225262816@mail.gmail.com>

On Mon, 2008-12-15 at 17:12 +0100, Stefanik G=C3=A1bor wrote:
> On Mon, Dec 15, 2008 at 5:04 PM, Dan Williams <dcbw@redhat.com> wrote=
:
> > On Mon, 2008-12-15 at 16:47 +0100, Stefanik G=C3=A1bor wrote:
> >> This patch regressed support for aireplay-ng's "fragmentation atta=
ck" feature!
> >>
> >> Prior to the landing of this patch (as commit
> >> caeb36d73b23b52a0ea2a8368502ef8230fa67b3), applying the patch @
> >> http://patches.aircrack-ng.org/mac80211_2.6.28-rc4-wl_frag+ack_v2.=
patch
> >> allowed aireplay-ng's fragmentation attack to work with almost all
> >> mac80211 drivers, including ath5k. After the landing of this patch=
,
> >> the attack fails with "No answer, repeating...". (Regression found
> >> using git bisect, and verified by local backout of commit
> >> caeb36d73b23b52a0ea2a8368502ef8230fa67b3.)
> >
> > Unless I misunderstand...  but not all drivers will report their MA=
C
> > address until they have opened the device (ie, add_interface time),
> > because not all devices load firmware until the interface is opened=
, and
> > thus some cannot read their MAC address until that time.
> >
> > So aireplay-ng is broken if it relies on the device having a valid =
mac
> > address before the device is opened.
> >
> > Dan
> >
>=20
> That is not the problem - aireplay-ng operates on a monitor interface
> that is already up. Likely this patch somehow misses monitor
> interfaces.

Ah, ok.  Ignore my mail then :)

dan


--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2008-12-15 16:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-18  4:40 [PATCH] ath5k: set mac address in add_interface Bob Copeland
2008-11-21 19:49 ` Maxim Levitsky
2008-11-21 20:01   ` [ath5k-devel] " Bob Copeland
2008-11-21 20:53     ` Maxim Levitsky
2008-11-21 21:45       ` Maxim Levitsky
2008-11-21 23:15         ` Bob Copeland
2008-11-22 13:25           ` Maxim Levitsky
2008-12-15 15:47 ` Stefanik Gábor
2008-12-15 16:04   ` Dan Williams
2008-12-15 16:12     ` Stefanik Gábor
2008-12-15 16:22       ` Dan Williams [this message]
2008-12-15 17:16       ` [ath5k-devel] " Bob Copeland
2008-12-16 14:58         ` Bob Copeland
2008-12-16 15:01           ` Johannes Berg
2008-12-19 15:15             ` Bob Copeland
2008-12-20  9:46               ` Johannes Berg
2008-12-16 15:42           ` Stefanik Gábor
     [not found]   ` <20081215161435.M87237@bobcopeland.com>
2008-12-15 16:30     ` Stefanik Gábor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1229358152.12163.64.camel@localhost.localdomain \
    --to=dcbw@redhat.com \
    --cc=ath5k-devel@venema.h4ckr.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=maximlevitsky@gmail.com \
    --cc=me@bobcopeland.com \
    --cc=netrolller.3d@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).