* [RFC] mac80211: Print unknown packet type
@ 2008-12-17 18:27 Larry Finger
2008-12-17 18:15 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Larry Finger @ 2008-12-17 18:27 UTC (permalink / raw)
To: Johannes Berg; +Cc: wireless
Johannes,
I'm trying to find a problem with p54usb that causes it to go belly-up under
stress testing. In one of my runs, I hit the WARN_ON in
ieee80211_tasklet_handler(). Unfortunately, I got no indication of what was in
skb->pkt_type, just that it was not one of the expected types.
Do you think that adding the printk below would be worthwhile?
Thanks,
Larry
---
Index: wireless-testing/net/mac80211/main.c
===================================================================
--- wireless-testing.orig/net/mac80211/main.c
+++ wireless-testing/net/mac80211/main.c
@@ -341,6 +341,8 @@ static void ieee80211_tasklet_handler(un
dev_kfree_skb(skb);
break ;
default:
+ printk(KERN_INFO "mac80211: Packet is of unknown type"
+ " %d\n", skb->pkt_type);
WARN_ON(1);
dev_kfree_skb(skb);
break;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC] mac80211: Print unknown packet type
2008-12-17 18:27 [RFC] mac80211: Print unknown packet type Larry Finger
@ 2008-12-17 18:15 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2008-12-17 18:15 UTC (permalink / raw)
To: Larry Finger; +Cc: wireless
On Wed, 2008-12-17 at 12:27 -0600, Larry Finger wrote:
> Johannes,
>
> I'm trying to find a problem with p54usb that causes it to go belly-up under
> stress testing. In one of my runs, I hit the WARN_ON in
> ieee80211_tasklet_handler(). Unfortunately, I got no indication of what was in
> skb->pkt_type, just that it was not one of the expected types.
That really points to memory corruption somewhere.
> Do you think that adding the printk below would be worthwhile?
>
> Thanks,
>
> Larry
> ---
>
> Index: wireless-testing/net/mac80211/main.c
> ===================================================================
> --- wireless-testing.orig/net/mac80211/main.c
> +++ wireless-testing/net/mac80211/main.c
> @@ -341,6 +341,8 @@ static void ieee80211_tasklet_handler(un
> dev_kfree_skb(skb);
> break ;
> default:
> + printk(KERN_INFO "mac80211: Packet is of unknown type"
> + " %d\n", skb->pkt_type);
> WARN_ON(1);
Seems reasonable to me. I'd do
+ WARN(1, "mac80211: ...", skb->pkt_type);
- WARN_ON(1);
instead.
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-17 18:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-17 18:27 [RFC] mac80211: Print unknown packet type Larry Finger
2008-12-17 18:15 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).