From: Johannes Berg <johannes@sipsolutions.net>
To: David Kilroy <kilroyd@googlemail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] wireless: Add channel/frequency conversions
Date: Sun, 21 Dec 2008 11:36:22 +0100 [thread overview]
Message-ID: <1229855782.4953.8.camel@johannes> (raw)
In-Reply-To: <1229797871-21179-1-git-send-email-kilroyd@googlemail.com> (sfid-20081220_193122_880708_FEC683E0)
[-- Attachment #1: Type: text/plain, Size: 798 bytes --]
On Sat, 2008-12-20 at 18:31 +0000, David Kilroy wrote:
> While refactorring orinoco I found I was encapsulating the static
> channel frequency table. A quick poll of drivers showed that a number of
> the older driver have their own version of the table, and use it in the
> same way. So rather than keep this to orinoco I added the function to
> the ieee80211 header.
>
> To be complete I've added conversion routines for all the
> bands/modulations in IEEE 802.11-2007
>
> Does this seem reasonable? Should they go somewhere else?
Seems fine, though maybe lib80211 would be appropriate? I'd hate using
lib80211 in cfg80211 though since that pulls in all crypto bits that we
don't need there. OTOH, the code really isn't big, so I wouldn't worry
about inlining them.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-12-21 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-20 18:31 [RFC] wireless: Add channel/frequency conversions David Kilroy
2008-12-21 10:36 ` Johannes Berg [this message]
2008-12-22 10:28 ` Dave
2008-12-22 10:49 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229855782.4953.8.camel@johannes \
--to=johannes@sipsolutions.net \
--cc=kilroyd@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).