From: Johannes Berg <johannes@sipsolutions.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John W Linville <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rtl8180: Fix to add STA mode
Date: Mon, 22 Dec 2008 07:56:36 +0100 [thread overview]
Message-ID: <1229928996.3087.3.camel@johannes> (raw)
In-Reply-To: <494eb7d1.t197ktKMLMlIer8t%Larry.Finger@lwfinger.net> (sfid-20081221_224041_525205_B0C21FE7)
[-- Attachment #1: Type: text/plain, Size: 1514 bytes --]
On Sun, 2008-12-21 at 15:40 -0600, Larry Finger wrote:
> To be compatible with mac80211 following commit 3fc7826b95521 (mac80211:
> only create default STA interface if supported), rtl8180 needs to set
> NL80211_IFTYPE_STATION in interface_modes.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Reported-by: Fabio Rossi <rossi.f@inwind.it>
> Tested-by: Piter PUNK <piterpunk@unitednerds.org>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
obviously. I didn't know we'd missed an in-tree driver when adding the
interface_modes thing, thanks.
> ---
>
> John,
>
> This patch should be included with the 2.6.29 material.
>
> Larry
> ---
>
> Index: wireless-testing/drivers/net/wireless/rtl818x/rtl8180_dev.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/rtl818x/rtl8180_dev.c
> +++ wireless-testing/drivers/net/wireless/rtl818x/rtl8180_dev.c
> @@ -898,6 +898,7 @@ static int __devinit rtl8180_probe(struc
> dev->flags = IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING |
> IEEE80211_HW_RX_INCLUDES_FCS |
> IEEE80211_HW_SIGNAL_UNSPEC;
> + dev->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION);
> dev->queues = 1;
> dev->max_signal = 65;
>
> ---
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2008-12-22 6:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-21 21:40 [PATCH] rtl8180: Fix to add STA mode Larry Finger
2008-12-22 6:56 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229928996.3087.3.camel@johannes \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox