From: Johannes Berg <johannes@sipsolutions.net>
To: Luis Rodriguez <Luis.Rodriguez@Atheros.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>
Subject: Re: [PATCH v2 11/18] iwlwifi: make use of conf_is_ht*() helpers
Date: Mon, 22 Dec 2008 20:06:43 +0100 [thread overview]
Message-ID: <1229972803.4406.14.camel@johannes> (raw)
In-Reply-To: <1229970039-10561-12-git-send-email-lrodriguez@atheros.com>
[-- Attachment #1: Type: text/plain, Size: 3332 bytes --]
On Mon, 2008-12-22 at 10:20 -0800, Luis Rodriguez wrote:
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> drivers/net/wireless/iwlwifi/iwl-agn-rs.c | 6 +++---
> drivers/net/wireless/iwlwifi/iwl-agn.c | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-rs.c b/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
> index f032167..59d4e11 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
> @@ -1131,7 +1131,7 @@ static int rs_switch_to_mimo2(struct iwl_priv *priv,
> s32 rate;
> s8 is_green = lq_sta->is_green;
>
> - if (!conf->ht.enabled || !sta->ht_cap.ht_supported)
> + if (!conf_is_ht(conf) || !sta->ht_cap.ht_supported)
> return -1;
>
> if (((sta->ht_cap.cap & IEEE80211_HT_CAP_SM_PS) >> 2)
> @@ -1198,7 +1198,7 @@ static int rs_switch_to_siso(struct iwl_priv *priv,
> u8 is_green = lq_sta->is_green;
> s32 rate;
>
> - if (!conf->ht.enabled || !sta->ht_cap.ht_supported)
> + if (!conf_is_ht(conf) || !sta->ht_cap.ht_supported)
> return -1;
>
> IWL_DEBUG_RATE("LQ: try to switch to SISO\n");
> @@ -1998,7 +1998,7 @@ lq_update:
> * stay with best antenna legacy modulation for a while
> * before next round of mode comparisons. */
> tbl1 = &(lq_sta->lq_info[lq_sta->active_tbl]);
> - if (is_legacy(tbl1->lq_type) && !conf->ht.enabled &&
> + if (is_legacy(tbl1->lq_type) && !conf_is_ht(conf) &&
> lq_sta->action_counter >= 1) {
> lq_sta->action_counter = 0;
> IWL_DEBUG_RATE("LQ: STAY in legacy table\n");
> diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
> index 05cd04c..99a17d8 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-agn.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
> @@ -523,9 +523,9 @@ static void iwl_ht_conf(struct iwl_priv *priv,
> */
>
> iwl_conf->extension_chan_offset = IEEE80211_HT_PARAM_CHA_SEC_NONE;
> - if (priv->hw->conf.ht.channel_type == NL80211_CHAN_HT40MINUS)
> + if (conf_is_ht40_minus(&priv->hw->conf))
> iwl_conf->extension_chan_offset = IEEE80211_HT_PARAM_CHA_SEC_BELOW;
> - else if(priv->hw->conf.ht.channel_type == NL80211_CHAN_HT40PLUS)
> + else if (conf_is_ht40_plus(&priv->hw->conf))
> iwl_conf->extension_chan_offset = IEEE80211_HT_PARAM_CHA_SEC_ABOVE;
>
> /* If no above or below channel supplied disable FAT channel */
> @@ -2553,7 +2553,7 @@ static int iwl_mac_config(struct ieee80211_hw *hw, u32 changed)
> mutex_lock(&priv->mutex);
> IWL_DEBUG_MAC80211("enter to channel %d\n", conf->channel->hw_value);
>
> - priv->current_ht_config.is_ht = conf->ht.enabled;
> + priv->current_ht_config.is_ht = conf_is_ht(conf);
>
> if (conf->radio_enabled && iwl_radio_kill_sw_enable_radio(priv)) {
> IWL_DEBUG_MAC80211("leave - RF-KILL - waiting for uCode\n");
> --
> 1.6.1.rc3.51.g5832d
>
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-12-22 19:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-22 18:20 [PATCH v2 00/18] ath9k: first series for regulatory cleanup Luis R. Rodriguez
2008-12-22 18:20 ` [PATCH v2 01/18] mac80211: add HT conf helpers Luis R. Rodriguez
2008-12-22 18:20 ` [PATCH v2 02/18] ath9k: use hw->conf on ath_setcurmode() Luis R. Rodriguez
2008-12-22 18:20 ` [PATCH v2 03/18] ath9k: remove cache of rate preference when using 11g protection Luis R. Rodriguez
2008-12-22 18:20 ` [PATCH v2 04/18] ath9k: Rename ath_setcurmode() to ath_cache_conf_rate() Luis R. Rodriguez
2008-12-22 18:20 ` [PATCH v2 05/18] wireless: allow for private channel area Luis R. Rodriguez
2008-12-22 18:20 ` [PATCH v2 06/18] ath9k: start making use of channel->priv Luis R. Rodriguez
2008-12-22 18:20 ` [PATCH v2 07/18] ath9k: consolidate arguments on hw reset Luis R. Rodriguez
2008-12-22 18:20 ` [PATCH v2 08/18] ath9k: make request to get the noisefloor threshold band specific Luis R. Rodriguez
2008-12-22 18:20 ` [PATCH v2 09/18] ath9k: use ieee80211_conf on ath9k_hw_iscal_supported() Luis R. Rodriguez
2008-12-22 18:20 ` [PATCH v2 10/18] ath9k: make use of conf_is_ht*() in the rest of the driver Luis R. Rodriguez
2008-12-22 18:20 ` [PATCH v2 11/18] iwlwifi: make use of conf_is_ht*() helpers Luis R. Rodriguez
2008-12-22 18:20 ` [PATCH v2 12/18] mac80211: no need for ht.enabled Luis R. Rodriguez
2008-12-22 18:20 ` [PATCH v2 13/18] ath9k: Make ANI CCK and OFDM error triggers band specific Luis R. Rodriguez
2008-12-22 18:20 ` [PATCH v2 14/18] ath9k: remove mode specific default noise floor values Luis R. Rodriguez
2008-12-22 18:20 ` [PATCH v2 15/18] ath9k: remove ath9k_hw_chan2wmode() Luis R. Rodriguez
2008-12-22 18:20 ` [PATCH v2 16/18] ath9k: remove ath9k_hw_check_chan() Luis R. Rodriguez
2008-12-22 18:20 ` [PATCH v2 17/18] ath9k: remove superfluous check on changing channel Luis R. Rodriguez
2008-12-22 18:20 ` [PATCH v2 18/18] ath9k: fix sparse warnings Luis R. Rodriguez
2008-12-22 19:06 ` [PATCH v2 12/18] mac80211: no need for ht.enabled Johannes Berg
2008-12-22 19:06 ` Johannes Berg [this message]
2008-12-22 19:06 ` [PATCH v2 01/18] mac80211: add HT conf helpers Johannes Berg
2008-12-22 20:30 ` [PATCH v2 00/18] ath9k: first series for regulatory cleanup Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229972803.4406.14.camel@johannes \
--to=johannes@sipsolutions.net \
--cc=Luis.Rodriguez@Atheros.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox