From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Pavel Roskin <proski@gnu.org>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: allow mode change if IBSS is not allowed
Date: Tue, 23 Dec 2008 22:46:30 +0100 [thread overview]
Message-ID: <1230068790.31228.48.camel@johannes> (raw)
In-Reply-To: <20081223210705.GA12572@tuxdriver.com>
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
On Tue, 2008-12-23 at 16:07 -0500, John W. Linville wrote:
> On Mon, Dec 22, 2008 at 10:52:58PM +0100, Johannes Berg wrote:
> > On Mon, 2008-12-22 at 16:39 -0500, Pavel Roskin wrote:
> > > Changing mode on an interface is not allowed if IBSS is disabled for the
> > > current channel. That restriction should only apply when switching to
> > > the ad-hoc mode, as it was prior to db17d8c4.
> > >
> > > Signed-off-by: Pavel Roskin <proski@gnu.org>
> >
> > Thanks Pavel.
> >
> > Acked-by: Johannes Berg <johannes@sipsolutions.net>
>
> Doesn't this need to account for the other beaconing modes?
Well, for now this fixes the regression I introduced, and how the other
modes should be handled we haven't really defined yet. But yeah, it
might make some sense for mesh too...
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2008-12-23 21:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-22 21:39 [PATCH] mac80211: allow mode change if IBSS is not allowed Pavel Roskin
2008-12-22 21:52 ` Johannes Berg
2008-12-23 21:07 ` John W. Linville
2008-12-23 21:46 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1230068790.31228.48.camel@johannes \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).