From: Pavel Roskin <proski@gnu.org>
To: Kalle Valo <kalle.valo@iki.fi>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: add declarations for wake/stop_queue_by_reason()
Date: Sun, 28 Dec 2008 16:36:00 -0500 [thread overview]
Message-ID: <1230500160.25726.7.camel@dv> (raw)
In-Reply-To: <20081228185414.6204.97451.stgit@tikku>
On Sun, 2008-12-28 at 20:54 +0200, Kalle Valo wrote:
> Fixes sparse warnings:
>
> net/mac80211/util.c:355:6: warning: symbol
> 'ieee80211_wake_queue_by_reason' was not declared. Should it be static?
> net/mac80211/util.c:385:6: warning: symbol
> 'ieee80211_stop_queue_by_reason' was not declared. Should it be static?
...
> +void ieee80211_wake_queue_by_reason(struct ieee80211_hw *hw, int queue,
> + enum queue_stop_reason reason);
> +void ieee80211_stop_queue_by_reason(struct ieee80211_hw *hw, int queue,
> + enum queue_stop_reason reason);
What's the point in declaring functions that are not used elsewhere?
Why not make them static as sparse suggests? And if those function are
going to be used by other modules, maybe they should be exported?
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-12-28 21:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-28 18:54 [PATCH] mac80211: add declarations for wake/stop_queue_by_reason() Kalle Valo
2008-12-28 21:36 ` Pavel Roskin [this message]
2008-12-29 6:03 ` Kalle Valo
2008-12-29 8:02 ` [PATCH v2] mac80211: make wake/stop_queue_by_reason() functions static Kalle Valo
2008-12-29 10:51 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1230500160.25726.7.camel@dv \
--to=proski@gnu.org \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).