Re: [PATCH v2] mac80211: make wake/stop_queue_by_reason() functions static

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 2127 bytes --]

On Mon, 2008-12-29 at 10:02 +0200, Kalle Valo wrote:
> Fixes sparse warnings:
> 
> net/mac80211/util.c:355:6: warning: symbol
>   'ieee80211_wake_queue_by_reason' was not declared. Should it be static?
> net/mac80211/util.c:385:6: warning: symbol
>   'ieee80211_stop_queue_by_reason' was not declared. Should it be static?
> 
> Thanks to Johannes Berg for reporting this.
> 
> Signed-off-by: Kalle Valo <kalle.valo@iki.fi>

Acked-by: Johannes Berg <johannes@sipsolutions.net>

Your discussion was a little quirky though; they weren't exported to
drivers by listing them in ieee80211_i.h, and we might well want to use
them in other parts of mac80211 later (and will just make them
non-static at that point)

> ---
> 
>  net/mac80211/util.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/net/mac80211/util.c b/net/mac80211/util.c
> index fb89e1d..5cd4303 100644
> --- a/net/mac80211/util.c
> +++ b/net/mac80211/util.c
> @@ -352,8 +352,8 @@ static void __ieee80211_wake_queue(struct ieee80211_hw *hw, int queue,
>  	}
>  }
>  
> -void ieee80211_wake_queue_by_reason(struct ieee80211_hw *hw, int queue,
> -				    enum queue_stop_reason reason)
> +static void ieee80211_wake_queue_by_reason(struct ieee80211_hw *hw, int queue,
> +					   enum queue_stop_reason reason)
>  {
>  	struct ieee80211_local *local = hw_to_local(hw);
>  	unsigned long flags;
> @@ -382,8 +382,8 @@ static void __ieee80211_stop_queue(struct ieee80211_hw *hw, int queue,
>  	netif_stop_subqueue(local->mdev, queue);
>  }
>  
> -void ieee80211_stop_queue_by_reason(struct ieee80211_hw *hw, int queue,
> -				    enum queue_stop_reason reason)
> +static void ieee80211_stop_queue_by_reason(struct ieee80211_hw *hw, int queue,
> +					   enum queue_stop_reason reason)
>  {
>  	struct ieee80211_local *local = hw_to_local(hw);
>  	unsigned long flags;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]