From: Johannes Berg <johannes@sipsolutions.net>
To: Vivek Natarajan <vivek.natraj@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k: Enable dynamic power save in ath9k.
Date: Mon, 29 Dec 2008 13:14:21 +0100 [thread overview]
Message-ID: <1230552861.3116.34.camel@johannes> (raw)
In-Reply-To: <1230552660.3116.33.camel@johannes> (sfid-20081229_131046_790819_4EFBD29E)
[-- Attachment #1: Type: text/plain, Size: 630 bytes --]
On Mon, 2008-12-29 at 13:11 +0100, Johannes Berg wrote:
> On Mon, 2008-12-29 at 15:53 -0800, Vivek Natarajan wrote:
>
> > +#define ATH9K_PS_WAKEUP(sc) \
> > + do { \
> > + if (!atomic_read(&sc->ps_usecount) && \
> > + (ah->ah_powerMode != ATH9K_PM_AWAKE)) { \
> > + ah->ah_restoreMode = ah->ah_powerMode; \
> > + ath9k_hw_setpower(sc->sc_ah, ATH9K_PM_AWAKE); \
> > + } \
> > + atomic_inc(&sc->ps_usecount); \
> > + } while (0);
Also, this seems racy, shouldn't it use something like if
(atomic_inc_return() == 1) ?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-12-29 12:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 23:53 [PATCH] ath9k: Enable dynamic power save in ath9k Vivek Natarajan
2008-12-29 12:11 ` Johannes Berg
2008-12-29 12:14 ` Johannes Berg [this message]
2008-12-29 12:23 ` Michael Buesch
2008-12-29 13:37 ` Vivek Natarajan
2009-01-09 19:51 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1230552861.3116.34.camel@johannes \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vivek.natraj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox