From: Pavel Roskin <proski@gnu.org>
To: Vivek Natarajan <vivek.natraj@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] ath9k: Enable dynamic power save in ath9k.
Date: Mon, 29 Dec 2008 11:40:56 -0500 [thread overview]
Message-ID: <1230568856.20811.6.camel@dv> (raw)
In-Reply-To: <20081229145920.GC2914@myhost.users.atheros.com>
On Mon, 2008-12-29 at 20:29 +0530, Vivek Natarajan wrote:
> u16 ah_currentRD5G;
> u16 ah_currentRD2G;
> char ah_iso[4];
> + enum ath9k_power_mode ah_powerMode;
> + enum ath9k_power_mode ah_restoreMode;
I think camelCase is discouraged in Linux sources. Sure, there are
exceptions, but they are normally caused by names used in standards or
other documentation. I cannot find "powerMode" in any drivers other
than ath9k.
> - enum ath9k_power_mode ah_powerMode;
That's good. Let's follow Linux conventions for the new variable names.
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2008-12-29 16:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 14:59 [PATCH v3] ath9k: Enable dynamic power save in ath9k Vivek Natarajan
2008-12-29 16:40 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1230568856.20811.6.camel@dv \
--to=proski@gnu.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vivek.natraj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).